add migrator for moving relevant_protocols to protocol_link PR21
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynnz22
changed the title
eecavanna
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Looks good to me. Thanks for summarizing the changes in the PR description.
Note: This migrator has the "original" structure because the recent upstream changes to the migration framework (e.g. the introduction of adapters) haven't been propagated to this repo yet.
|
Side note: I'm surprised the new slot's name is singular instead of plural. I consider that topic to be outside the scope of this PR, though. |
|
This branch looks good to me, as of the latest commit. |
turbomam
approved these changes
Feb 7, 2024
brynnz22
changed the title
relevant_protocols to protocol_link PR21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the migration code that addresses PR: #21
It moves any links that currently exist in the
relevant_protocolsslot over to theprotocol_linkslot and removesrelevant_protocolsfrom the study.This migration is not dependent on any others.