-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove AnalyticalSample
class from schema
#77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brynnz22 I did a quick search for AnalyticalSample & it looks like this class is mentioned in
notebooks/in-repo-anaggregateds-report.ipynb
&
assets/TermsUpdated_organicmatterextraction/TermsUpdated_organicmatterextraction.tsv
I was checking for example files. There are none, so I think this is good to be merged. Just wanted to note the above in the event it mattered for migrtation.
@turbomam I removed the |
Thanks for doing that research @mslarae13 and @brynnz22 I will run the notebook and let you know if I had to do anything tricky. I agree that this is a low risk situation, since the string As for |
AnalyticalSample
class from schema
No migration needed IF AnalyticalSample was never used |
This PR removes the AnalyticalSample class from the schema.
Addresses issue microbiomedata#1681