Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair MIXS environment annotations #197

Closed
Tracked by #587
ssarrafan opened this issue Oct 29, 2021 · 7 comments
Closed
Tracked by #587

Repair MIXS environment annotations #197

ssarrafan opened this issue Oct 29, 2021 · 7 comments
Assignees
Labels
backlog Issue not assigned to a sprint or not completed during a sprint. Needs to be reprioritized. nmdc-schema-mixs-submission

Comments

@ssarrafan
Copy link
Collaborator

MIXS environment repair annotations to the format: label1 (D1) label2 (D2)...

On the Nov list for refactoring

@ssarrafan ssarrafan added this to the Sprint 8 milestone Oct 29, 2021
@ssarrafan
Copy link
Collaborator Author

Leaving this in the current sprint based on the mid-sprint review but let me know if it should be moved to December @turbomam

@ssarrafan
Copy link
Collaborator Author

Adding the backlog label and removing from sprint per @turbomam via Slack

@ssarrafan ssarrafan added the backlog Issue not assigned to a sprint or not completed during a sprint. Needs to be reprioritized. label Nov 30, 2021
@ssarrafan ssarrafan removed this from the Sprint 8 milestone Nov 30, 2021
@wdduncan
Copy link
Contributor

wdduncan commented Feb 3, 2022

@ssarrafan @turbomam Should we leave this open or close it?

@ssarrafan
Copy link
Collaborator Author

@wdduncan Mark had suggested we add it to the backlog to be reprioritized. If we think it's done or not relevant I'm happy to close it.

@turbomam
Copy link
Member

turbomam commented Feb 4, 2022

This is somewhat intertwined with the issue of how MIxS content gets merged into the NMDC schema. I can't remember the issue for that off-hand

For a short term solution, we could move the specification for these columns into @mslarae13's mixs_modified_slots tab

@wdduncan
Copy link
Contributor

wdduncan commented Feb 4, 2022

Is mixs_modified_slots at data harmonizer thing, a nmdc-schema thing, or both? We should sort this out.

Merging mixs content into the nmdc-schema is straightforward:

  • the mixs.yaml file is updated (either manually or programmatically)
  • the updated mixs.yaml is then incorporated into the schema

@ssarrafan
Copy link
Collaborator Author

@turbomam this issue is pretty old and we've had new versions since so closing this one out but let me know if we still need to keep this in the backlog to be worked on.

turbomam pushed a commit that referenced this issue Jun 17, 2024
…-make-migrator-that-removes-metagenomeannotationgold_analysis_project_identifiers-field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issue not assigned to a sprint or not completed during a sprint. Needs to be reprioritized. nmdc-schema-mixs-submission
Projects
None yet
Development

No branches or pull requests

3 participants