Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

short term: programmatically tag the origin of MIxS terms when imported into NMDC schema #252

Open
Tracked by #587
turbomam opened this issue Feb 2, 2022 · 11 comments
Assignees
Labels
backlog Issue not assigned to a sprint or not completed during a sprint. Needs to be reprioritized. nmdc-schema-mixs-submission
Milestone

Comments

@turbomam
Copy link
Member

turbomam commented Feb 2, 2022

CC @cmungall @wdduncan

Sample MIxS term in NMDC shema

see also microbiomedata/nmdc-server#555

especially the discussion of MIxS' lat_lon field

@turbomam
Copy link
Member Author

turbomam commented Feb 2, 2022

Implement with conforms_to or annotations?

semantics too loose?

  • in_subset
  • see_also

probably not

  • quick and dirty parse of slot_uri, from_schema, imported_from, exact_mappings etc.
  • owner (deprecated)

@wdduncan
Copy link
Contributor

wdduncan commented Feb 3, 2022

tagging @mslarae13

@cmungall
Copy link
Collaborator

cmungall commented Feb 4, 2022 via email

@turbomam
Copy link
Member Author

turbomam commented Jun 15, 2022

I implemented with source: http://w3id.org/mixs/terms in mixs.yaml

When creating the Bioscales tempalte, we found that the LinkML source attribute conflicts with a reserved source annotation in DataHarmonizer, so this might not be a good long term solution.

@turbomam
Copy link
Member Author

@turbomam
Copy link
Member Author

turbomam commented Jul 5, 2022

@ssarrafan : I think @pkalita-lbl and Damion resolved the over-eager interpretation of LinkML's source field. We still need to have better policies for DataHarmonizer vs. LinkML attributes

@ssarrafan ssarrafan modified the milestones: Sprint 15, Sprint 16 Jul 5, 2022
@mslarae13
Copy link
Contributor

@turbomam
Just checking, does this relate to the discussion we had yesterday about "annotating" the NMDC schema slots with "where they came from"?

Example, geo_loc_name being MIxS & location being gold ?

@turbomam
Copy link
Member Author

Just checking, does this relate to the discussion we had yesterday about "annotating" the NMDC schema slots with "where they came from"?

@mslarae13 @ssarrafan

Yes, but I'm not convinced I did it in a sustainable way, or that I used the most appropriate LinkML slot to make the annotations. Will look into it more in the beginning of August.

@ssarrafan
Copy link
Collaborator

Just checking, does this relate to the discussion we had yesterday about "annotating" the NMDC schema slots with "where they came from"?

@mslarae13 @ssarrafan

Yes, but I'm not convinced I did it in a sustainable way, or that I used the most appropriate LinkML slot to make the annotations. Will look into it more in the beginning of August.

I'm tempted to tag this as interim fix and close it but will move it to August for you @turbomam. FYI @mslarae13

@ssarrafan ssarrafan modified the milestones: Sprint 16, Sprint 17 Jul 28, 2022
@mslarae13
Copy link
Contributor

Just checking, does this relate to the discussion we had yesterday about "annotating" the NMDC schema slots with "where they came from"?

@mslarae13 @ssarrafan
Yes, but I'm not convinced I did it in a sustainable way, or that I used the most appropriate LinkML slot to make the annotations. Will look into it more in the beginning of August.

I'm tempted to tag this as interim fix and close it but will move it to August for you @turbomam. FYI @mslarae13

@ssarrafan I agree interim fix. Can we get a ticket started for the "preferred solution" per Mark's comment

@ssarrafan
Copy link
Collaborator

@sujaypatil96 @turbomam can this interim fix issue be closed?

I'm moving to Sept sprint but if you plan to not work on it in the next 2 weeks let me know so I can remove and add the backlog label

@ssarrafan ssarrafan removed this from the Sprint 17 milestone Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issue not assigned to a sprint or not completed during a sprint. Needs to be reprioritized. nmdc-schema-mixs-submission
Projects
None yet
Development

No branches or pull requests

6 participants