Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub workflow to preview documentation changes/builds with example changes #2057

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

sujaypatil96
Copy link
Collaborator

Testing fix for linkml/linkml#2029

Copy link

github-actions bot commented Jun 10, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2057/
on branch gh-pages at 2024-06-10 23:57 UTC

@sujaypatil96 sujaypatil96 marked this pull request as ready for review June 11, 2024 00:01
@sujaypatil96 sujaypatil96 linked an issue Jun 11, 2024 that may be closed by this pull request
@sujaypatil96
Copy link
Collaborator Author

Testing a fix for #1588 here.

See original/current example deployed subset documentation page: https://microbiomedata.github.io/nmdc-schema/WorkflowSubset/

Compare with fixed subset documentation page here: https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2057/WorkflowSubset/

Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theoretically could have been two PRs, but both aspects of this are great

@turbomam
Copy link
Member

turbomam commented Jun 12, 2024

crazy speculative questions:

  • what would happen if we had a schema element called pr-preview?
  • do old previews ever get removed? if not , what are the costs of that?

Even for great PRs, we should always try to anticipate the future costs

@turbomam
Copy link
Member

turbomam commented Jun 12, 2024

Please add the same thing to berkeley-schema-fy24 so we don't have to do a backmerege just for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subsets documentation pages should not reiterate descriptions
2 participants