Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic walker doesn't fire exitOperation or exitModelProperty #4379

Closed
4 tasks done
bterlson opened this issue Sep 9, 2024 · 1 comment · Fixed by #4381
Closed
4 tasks done

Semantic walker doesn't fire exitOperation or exitModelProperty #4379

bterlson opened this issue Sep 9, 2024 · 1 comment · Fixed by #4381
Assignees
Labels
bug Something isn't working needs-area

Comments

@bterlson
Copy link
Member

bterlson commented Sep 9, 2024

Describe the bug

The emit is missing from these methods.

Reproduction

navigateType(someModel, {
  exitModelProperty() { /* never fired */ }
})

navigateType(someOperation, {
  exitOperation() { /* never fired */ }
})

Checklist

@bterlson bterlson added the bug Something isn't working label Sep 9, 2024
@bterlson
Copy link
Member Author

bterlson commented Sep 9, 2024

Would be good to spot check the other methods to make sure no other emits are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants