[Bug] Fix semantic walker not firing exitOperation or exitModelProperty #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlitzelMendez
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
|
All changed packages have been documented.
Show changes
|
timotheeguerin
approved these changes
Sep 10, 2024
|
You can try these changes here
|
chrisradek
reviewed
Sep 10, 2024
| @@ -229,6 +229,7 @@ function navigateOperationType(operation: Operation, context: NavigationContext) | |||
| if (operation.sourceOperation) { | |||
| navigateTypeInternal(operation.sourceOperation, context); | |||
| } | |||
| context.emit("exitOperation", operation); | |||
There was a problem hiding this comment.
Sorry for the late comment - but I think the exit methods still won't be executed if the pre-order callback sets no recursion. Maybe not a real issue if it's unlikely someone would use both pre and post-order callbacks.
There was a problem hiding this comment.
oh I thought that was the expected behavior, but makes sense, I will follow up on this
chrisradek
reviewed
Sep 10, 2024
| namespaces: [] as Namespace[], | ||
| operations: [] as Operation[], | ||
| exitOperations: [] as Operation[], |
There was a problem hiding this comment.
Is there any reason not to extend the post-order callbacks to every type? Looks like we might still be missing some like namespaces, interfaces, etc.
sarangan12
pushed a commit
to sarangan12/typespec
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #4379