Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set response doc when an envelope #4322

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Fix set response doc when an envelope #4322

merged 3 commits into from
Sep 7, 2024

Conversation

timotheeguerin
Copy link
Member

fix #3664

@timotheeguerin timotheeguerin changed the title Fix set response doc when an envelop Fix set response doc when an envelope Sep 3, 2024
@timotheeguerin timotheeguerin mentioned this pull request Sep 3, 2024
Closed
3 tasks
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 3, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/http
Show changes

@typespec/http - fix ✏️

Use user provided description of model if model has a status code property(detect it as an response envelope)

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

markcowl
markcowl approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and update the batch spec to avoid doc changes, and this should be good.

@timotheeguerin timotheeguerin added this pull request to the merge queue Sep 6, 2024
Merged via the queue into microsoft:main with commit f4c8710 Sep 7, 2024
22 checks passed
@timotheeguerin timotheeguerin deleted the fix/response-doc-envelope branch September 7, 2024 00:04
@MaryGao MaryGao mentioned this pull request Sep 12, 2024
Merged
sarangan12 pushed a commit to sarangan12/typespec that referenced this pull request Sep 16, 2024
@timotheeguerin @sarangan12
Fix set response doc when an envelope (microsoft#4322)
2b4ecca 
fix [microsoft#3664](microsoft#3664)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
lib:http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow different description per status code
3 participants
@timotheeguerin @azure-sdk @markcowl