[gstreamer][gst-rtsp-server] Support Linux, fix OSX build and fix pkgconfig #20814
Conversation
JackBoosY
added
category:port-feature
JackBoosY
added
the
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
changed the title
|
ports/gstreamer/portfile.cmake
Outdated
| if(VCPKG_TARGET_IS_WINDOWS) | ||
| # note: can't find where z.lib comes from. replace it to appropriate library name manually | ||
| get_filename_component(BUILD_NINJA_DBG ${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-dbg/build.ninja ABSOLUTE) | ||
| get_filename_component(BUILD_NINJA_DBG "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-dbg/build.ninja" ABSOLUTE) | ||
| vcpkg_replace_string(${BUILD_NINJA_DBG} "z.lib" "zlibd.lib") | ||
| get_filename_component(BUILD_NINJA_REL ${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/build.ninja ABSOLUTE) | ||
| get_filename_component(BUILD_NINJA_REL "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/build.ninja" ABSOLUTE) | ||
| vcpkg_replace_string(${BUILD_NINJA_REL} "z.lib" "zlib.lib") | ||
| vcpkg_replace_string(${BUILD_NINJA_REL} "\"-Wno-unused\"" "") # todo: may need a patch for `gst_debug=false` | ||
| endif() |
There was a problem hiding this comment.
Wait what? Remove these lines completely and figure out where those come from. Either there is a find_dependency(find_library) like call in the build or one of the dependent pkg-config files is linking zlib wrongly.
These are the only two sources where it might come from.
There was a problem hiding this comment.
What about the osx regression in my comment above? Is that related to this?
There was a problem hiding this comment.
Probably not. @BillyONeal already looked at that and upstream probably has to fix it:
https://discord.com/channels/400588936151433218/687365466422902841/898363282887426088
https://discord.com/channels/400588936151433218/687365466422902841/898366845940285521
There was a problem hiding this comment.
@Neumann-A I couldn't access this discord channel, anyway, it seems like a upstream bug.
If the upstream doesn't have any respose in these days, I will revert the baseline changes and keep it to fail.
There was a problem hiding this comment.
z.lib might come from -lz in a pkg-config file, when calling pkg-config --msvc-syntax ....
There was a problem hiding this comment.
@dg0yt If it's true, does this mean that there is a common issue with pkgconfig in Windows?
There was a problem hiding this comment.
does this mean that there is a common issue with pkgconfig in Windows?
There is a common issues with people assuming stuff which isn't true. A lot of ports using cmake assume pkg-config is only available on UNIX system. They in addition assume there is probably no pkg-config file for all their dependencies and just hardcode wrong stuff into Libs: . -lz in Libs is just one very common example for this.
I don't know why this even crept in the unix package world..... I mean not deploying pc files .....
There was a problem hiding this comment.
@JackBoosY No. It is just some packages blindly adding -lz, and some ports installing pc files without review. And you don't notice it until you use it.
(In vcpkg, I have .pc file issues with openssl and netcdf-c, in addition to the pending PRs. gdal+nmake+pkg-config turns out to be a great test case.)
There was a problem hiding this comment.
also use something like
zlib_dep = dependency('zlib', required : true)
if not zlib_dep.found()
message('TEST ZLIB not found!') # a) check meson syntax; don't know if message is correct. b) I doubt this will ever trigger.
endif
There was a problem hiding this comment.
Indeed there must be one who adds -lz but couldn't find it.
#17394 (comment)
I previously confirmed that @Neumann-A 's suggestion is working well
zlib_dep = dependency('zlib', required : true) # in WindowsI can't remember well what was in the generated build.ninja. Probably both zlib path(in the ${vcpkg_root}/installed/${triplet}/...) and -lz together?
|
For osx regression, the upstream issue: https://gitlab.freedesktop.org/gstreamer/gst-build/-/issues/186. |
JackBoosY
added
the
depends:upstream-changes
JackBoosY
changed the title
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 699c8779f1b0feb4ed3564716d1ed31f69663ea6 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/g-/gstreamer.json b/versions/g-/gstreamer.json
index ceecb2b..d813c8c 100644
--- a/versions/g-/gstreamer.json
+++ b/versions/g-/gstreamer.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "07be58a4726cc70bfb1e44455804bb117805e8f0",
+ "git-tree": "d0f8d5d0a7204411a1ef31c8de847525e879a732",
"version": "1.19.2",
"port-version": 2
},
|
Close and reopen this PR to retrigger the suggestion agent. |
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/gst-rtsp-server/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/gst-rtsp-server/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/gst-rtsp-server/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for gst-rtsp-server but no changes to version or port version.
-- Version: 1.19.2#2
-- Old SHA: 7ee8619e03c47128fc5c633393e965436c769d29
-- New SHA: df17772b4069b1cd540b21804cc3397582831032
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout e809a42f87565e803b2178a0c11263f462d1800a -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 4a518eb7..1b790e73 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5910,7 +5910,7 @@
},
"qtmultimedia": {
"baseline": "6.2.4",
- "port-version": 0
+ "port-version": 1
},
"qtnetworkauth": {
"baseline": "6.2.4",
diff --git a/versions/q-/qtmultimedia.json b/versions/q-/qtmultimedia.json
index fc552d13..1bce662e 100644
--- a/versions/q-/qtmultimedia.json
+++ b/versions/q-/qtmultimedia.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "270c58ea89a27c45c553756bb6a5f6d69b3a4b10",
+ "version": "6.2.4",
+ "port-version": 1
+ },
{
"git-tree": "d0e46329a8e66cf3f95eca5d4018c955a8b54a15",
"version": "6.2.4",
|
The OSX regression fixed by the upstream PR: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2261 |
Add Linux support, fix OSX build and fix gstreamer components's pkgconfig files.
Fixes #20785 #20812.
Related PR: #20555.