-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gstreamer][gst-rtsp-server] Support Linux, fix OSX build and fix pkgconfig #20814
Closed
Closed
Changes from 12 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
f257db9
[gstreamer] Support Linux and fix pkgconfig
e270e38
version
78fab4f
remove baseline record
e2c32fd
Fix installation
139ca90
version
ad39d0c
[gst-rtsp-server] Fix linux build
0aa25dc
version
ff58908
Add qtmultimedia:x64-linux to fail
c10f745
Test osx build
fc67192
Revert test code
374ef59
Revert test code
7c5d13c
version
9dadd27
Revert test code
26360c4
version
5154fd2
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
319a91d
version
b136daf
[gstreamer] build with 1.19.3 (#4)
luncliff 65ed040
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
3af53d7
Merge branch 'dev/jack/20785' of https://github.com/JackBoosY/vcpkg i…
ade3e07
[gstreamer] fix feature option 'flac' (#5)
luncliff 409e70f
Apply suggestion
a7f1258
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
1199e8f
version
4ac30ab
Merge branch 'master' into dev/jack/20785
JackBoosY 7c79a98
Add supports and dependency features
9036bef
version
329c336
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
84a16c5
Merge branch 'dev/jack/20785' of https://github.com/JackBoosY/vcpkg i…
61e795b
Correct the dependencies according to the platform
6caae4e
version
f85e524
Add supports, add license
e9fcd5b
version
10f388e
Try to avoid trigger gstreamer[plugins-bad]:x64-osx
1c3fa6b
Update dependencies
29863b4
Restore some changes
b38f27c
format manifest
2c41b52
version
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait what? Remove these lines completely and figure out where those come from. Either there is a find_dependency(find_library) like call in the build or one of the dependent pkg-config files is linking zlib wrongly.
These are the only two sources where it might come from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the osx regression in my comment above? Is that related to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not. @BillyONeal already looked at that and upstream probably has to fix it:
https://discord.com/channels/400588936151433218/687365466422902841/898363282887426088
https://discord.com/channels/400588936151433218/687365466422902841/898366845940285521
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Neumann-A I couldn't access this discord channel, anyway, it seems like a upstream bug.
If the upstream doesn't have any respose in these days, I will revert the baseline changes and keep it to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
z.lib
might come from-lz
in a pkg-config file, when callingpkg-config --msvc-syntax ...
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dg0yt If it's true, does this mean that there is a common issue with pkgconfig in Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a common issues with people assuming stuff which isn't true. A lot of ports using cmake assume pkg-config is only available on UNIX system. They in addition assume there is probably no pkg-config file for all their dependencies and just hardcode wrong stuff into
Libs:
.-lz
inLibs
is just one very common example for this.I don't know why this even crept in the unix package world..... I mean not deploying pc files .....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JackBoosY No. It is just some packages blindly adding
-lz
, and some ports installing pc files without review. And you don't notice it until you use it.(In vcpkg, I have .pc file issues with openssl and netcdf-c, in addition to the pending PRs. gdal+nmake+pkg-config turns out to be a great test case.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also use something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed there must be one who adds
-lz
but couldn't find it.#17394 (comment)
I previously confirmed that @Neumann-A 's suggestion is working well
I can't remember well what was in the generated build.ninja. Probably both zlib path(in the
${vcpkg_root}/installed/${triplet}/...
) and-lz
together?