[pkgconf] enable search for system libs on linux #23010

Neumann-A · 2022-02-09T08:41:25Z

This is required to make cmake 3.22 work since it will pickup pkgconf from vcpkg. As such pkgconf from vcpkg needs to be able to pickup system dependencies which it only can if the default paths are correctly set. Unfortunately I don't know of a way to get the correct paths from the system's pkg-config (maybe the paths can be dumped somehow? String literals in the binary?)

This also belongs in the category that the host build requires information for the target to correctly set pkgconf up.

@ras0219: Maybe you have a better solution?

(maybe build it from the contents of /etc/ld.so.conf /etc/ld.so.conf.d/*.conf ?)

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Neumann-A · 2022-02-09T09:22:13Z

@JackBoosY Feel free to propose a license here. I would probably go with none or custom. It is like MIT but not really MIT

ras0219-msft · 2022-02-09T20:57:12Z

Since these paths are target specific (e.g. a sysroot when cross compiling), it seems like we must not bake them in at compile time and instead they must be dynamically added to PKG_CONFIG_PATH within the context of the consuming triplet.

What do you mean specifically by

This is required to make cmake 3.22 work since it will pickup pkgconf from vcpkg.

Do you mean that if we want CMake to be able to use pkgconf from vcpkg, it needs system paths? Or are you saying that today CMake 3.22 is broken because it is erroneously finding pkgconf and you're proposing we fix it by making pkgconf work?

Another potential approach would be to generate script wrappers in the target triplets that prepend/append the appropriate values to PKG_CONFIG_PATH before forwarding to the true executable.

Neumann-A · 2022-02-09T21:10:13Z

Do you mean "If we want CMake to be able to use pkgconf from vcpkg, it needs system paths"?

If we want to use cmake 3.22 we need to have pkgconf behave like the system pkg-config because otherwise ports will fail sporadically since vcpkg.cmake is setup in such a way that find_program(PKGCONFIG_EXECUTABLE NAMES pkg-config pkgconf NAMES_PER_DIR) will preferably find pkgconf within vcpkg due to search order.

Or are you saying that today CMake 3.22 is broken because it is erroneously finding pkgconf
you're proposing we fix it by making pkgconf work?

I am proposing to make it work like the system one. For the cross-compiling case the users need to define the correct non-system behavior anyway.
Also it is not erroneously finding pkgconf it is finding pkgconf since I added that to cmake ;) The problem is just that our pkgconf currently does not behave like the system version. (due to missing proper default search paths.)

Neumann-A · 2022-02-09T21:37:54Z

So possible way to determine system defaults is to run

neumann@Iluinrandir:~$ strings -d /usr/bin/pkg-config | grep /include
/usr/include
neumann@Iluinrandir:~$ strings -d /usr/bin/pkg-config | grep /lib
/lib64/ld-linux-x86-64.so.2
/lib:/lib/i386-linux-gnu:/lib/x86_64-linux-gnu:/lib/x86_64-linux-gnux32:/lib32:/libx32:/usr/lib:/usr/lib/i386-linux-gnu:/usr/lib/x86_64-linux-gnu:/usr/lib/x86_64-linux-gnux32:/usr/lib32:/usr/libx32
/usr/local/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig

That would be

SYSTEM_INCLUDEDIR
(ignore)
SYSTEM_LIBDIRS
DEFAULT_PKGCONFIG_SEARCH_PATHS

similar result for libpkgconfig:

neumann@Iluinrandir:~$ strings -d /usr/lib/x86_64-linux-gnu/libpkgconf.so.3 | grep /lib
/usr/local/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig
/lib:/lib/i386-linux-gnu:/lib/x86_64-linux-gnu:/lib/x86_64-linux-gnux32:/lib32:/libx32:/usr/lib:/usr/lib/i386-linux-gnu:/usr/lib/x86_64-linux-gnu:/usr/lib/x86_64-linux-gnux32:/usr/lib32:/usr/libx32
neumann@Iluinrandir:~$ strings -d /usr/lib/x86_64-linux-gnu/libpkgconf.so.3 | grep /personality
/usr/share/pkgconfig/personality.d:/etc/pkgconfig/personality.d
neumann@Iluinrandir:~$ strings -d /usr/lib/x86_64-linux-gnu/libpkgconf.so.3 | grep /include
/usr/include

dg0yt · 2022-02-10T05:01:35Z

$ pkg-config --debug 2>&1 | grep 'directory #'
Cannot open directory #1 '/usr/local/lib/x86_64-linux-gnu/pkgconfig' in package search path: No such file or directory
Scanning directory #2 '/usr/local/lib/pkgconfig'
Cannot open directory #3 '/usr/local/share/pkgconfig' in package search path: No such file or directory
Scanning directory #4 '/usr/lib/x86_64-linux-gnu/pkgconfig'
Scanning directory #5 '/usr/lib/pkgconfig'
Scanning directory #6 '/usr/share/pkgconfig'

Neumann-A · 2022-02-10T07:40:30Z

After thinking about it I would like to have a solution which does not require the system pkg-config.

dg0yt · 2022-02-10T07:44:53Z

It is probably enough to use reasonable system paths plus user environment variable.

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

JackBoosY · 2022-02-10T08:47:24Z

It is probably enough to use reasonable system paths plus user environment variable.

The user may not installed pkgconfig yet.

dg0yt · 2022-02-10T09:03:12Z

It is probably enough to use reasonable system paths plus user environment variable.

The user may not installed pkgconfig yet.

No problem if it is not called.

Neumann-A · 2022-02-10T14:17:43Z

duplicate symbol '_METIS_NodeND' in:
    lib/Graclus/libgraclus.a(ometis.c.o)
    /Users/vagrant/Data/installed/x64-osx/debug/lib/libmetis.a(ometis.c.o)
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

ras0219-msft · 2022-02-10T18:53:28Z

#23010 (comment)

Finally! This particular issue has been very elusive to repro. Thanks :)

--

I 100% agree that we need a solution that doesn't rely on a system pkg-config (since that kinda defeats the point in a lot of ways :)). However, I think it's important that we offer users the option to control the results. Looking at the man page1, I see that

PKG_CONFIG_LIBDIR
Replaces the default pkg-config search directory.

So we should ensure that our solution respects that. For example, if we went with a script-wrapper solution like I mentioned above, the script wrapper should not append the system paths if this env was defined.

I'm additionally not familiar enough with current Linux to know how we should handle /lib, /lib64, /usr/lib, and /usr/lib64. There are also other systems like NixOS or Haiku that might have more challenging configurations. I note that the documentation says "By default, pkg-config looks in the directory prefix/lib/pkgconfig", so perhaps we should do something like:

Search for a pkg-config executable
If found, use $pkgconfig_exe/../lib/pkgconfig. If not found, assume /usr/lib/pkgconfig if host is linux and ??? if host is osx.

Perhaps there's something more clever that would be reasonable, like transforming all elements of $PATH as ../lib/pkgconfig

Neumann-A · 2022-02-10T20:42:02Z

Finally! This particular issue has been very elusive to repro. Thanks :)

I think there is an error in the CMakeLists.txt using an absolute path in the installation. Cmake tries to rm -r -f /lib/Graclus/libgraclus.a

So we should ensure that our solution respects that.

environment variable PKG_CONFIG_LIBDIR will be respect no matter what we set as the defaults. pkgconf has additional a personality.d file which can also be use to define some defaults.

Search for a pkg-config executable

this again requires system pkg-config

OpenSuse defaults:
libpkgconf:

/usr/include
/usr/lib64
/usr/lib64/pkgconfig:/usr/share/pkgconfig
/usr/share/pkgconfig/personality.d:/etc/pkgconfig/personality.d

pkg-config

/usr/include
/usr/lib64:/lib64:/usr/lib:/lib
/usr/local/lib64/pkgconfig:/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib64/pkgconfig:/usr/share/pkgconfig:/opt/kde3/lib64/pkgconfig

debian is like ubuntu
alpine (pkgconf):

/usr/include
/usr/lib
/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig
/usr/share/pkgconfig/personality.d:/etc/pkgconfig/personality.d

(That are the 3 linux distros I could find in WSL)

Neumann-A · 2022-02-10T21:26:22Z

gcc -v gives:

aneumann@Iluinrandir:~> gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib64/gcc/x86_64-suse-linux/7/lto-wrapper
OFFLOAD_TARGET_NAMES=hsa:nvptx-none
Target: x86_64-suse-linux
Configured with: ../configure --prefix=/usr --infodir=/usr/share/info --mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64 --enable-languages=c,c++,objc,fortran,obj-c++,ada,go --enable-offload-targets=hsa,nvptx-none, --without-cuda-driver --enable-checking=release --disable-werror --with-gxx-include-dir=/usr/include/c++/7 --enable-ssp --disable-libssp --disable-libvtv --disable-libcc1 --disable-plugin --with-bugurl=https://bugs.opensuse.org/ --with-pkgversion='SUSE Linux' --with-slibdir=/lib64 --with-system-zlib --enable-libstdcxx-allocator=new --disable-libstdcxx-pch --enable-version-specific-runtime-libs --with-gcc-major-version-only --enable-linker-build-id --enable-linux-futex --enable-gnu-indirect-function --program-suffix=-7 --without-system-libunwind --enable-multilib --with-arch-32=x86-64 --with-tune=generic --build=x86_64-suse-linux --host=x86_64-suse-linux
Thread model: posix
gcc version 7.5.0 (SUSE Linux)

or

neumann@Iluinrandir:~$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/10/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa:hsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 10.3.0-1ubuntu1~20.04' --with-bugurl=file:///usr/share/doc/gcc-10/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-10 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-10-S4I5Pr/gcc-10-10.3.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-10-S4I5Pr/gcc-10-10.3.0/debian/tmp-gcn/usr,hsa --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu --with-build-config=bootstrap-lto-lean --enable-link-mutex
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 10.3.0 (Ubuntu 10.3.0-1ubuntu1~20.04)

the follwing variables might be helpful:

--libdir
--with-slibdir
--build

JackBoosY · 2022-02-11T02:17:33Z

duplicate symbol '_METIS_NodeND' in:
    lib/Graclus/libgraclus.a(ometis.c.o)
    /Users/vagrant/Data/installed/x64-osx/debug/lib/libmetis.a(ometis.c.o)
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

Will be fixed in another PR.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d15470bb6464a3bb0ce3d98d118190cfd5189080 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/p-/pkgconf.json b/versions/p-/pkgconf.json
index 8277f3f..e4a222d 100644
--- a/versions/p-/pkgconf.json
+++ b/versions/p-/pkgconf.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "849c6b13074045c18f89394e7c7350efe8a630df",
+      "git-tree": "0338b251230ade33a8740f1da0fb4c209e34fb63",
       "version": "1.8.0",
       "port-version": 2
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/pkgconf/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field can be found in the documentation

Neumann-A · 2022-02-11T08:11:04Z

I think asking CMake for this stuff is the solution. Just need to run it on opensuse once.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for colmap but no changes to version or port version.
-- Version: 3.7
-- Old SHA: 81329023ad5f9b2bd27554d2d8a97f8e63aef708
-- New SHA: 0f09c643f7fef8b9a1ee89ba82f4d17c40b3a348
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d15470bb6464a3bb0ce3d98d118190cfd5189080 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/p-/pkgconf.json b/versions/p-/pkgconf.json
index 8277f3f..e4a222d 100644
--- a/versions/p-/pkgconf.json
+++ b/versions/p-/pkgconf.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "849c6b13074045c18f89394e7c7350efe8a630df",
+      "git-tree": "0338b251230ade33a8740f1da0fb4c209e34fb63",
       "version": "1.8.0",
       "port-version": 2
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/pkgconf/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field can be found in the documentation

Neumann-A · 2022-02-11T08:22:35Z

@ras0219-msft: hmm is the type of linux system part of the binary hash? If not this will definitely break binary caching since the output result will depend on system introspection not considered in the binary hash.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for colmap but no changes to version or port version.
-- Version: 3.7
-- Old SHA: 81329023ad5f9b2bd27554d2d8a97f8e63aef708
-- New SHA: 0f09c643f7fef8b9a1ee89ba82f4d17c40b3a348
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d15470bb6464a3bb0ce3d98d118190cfd5189080 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/p-/pkgconf.json b/versions/p-/pkgconf.json
index 8277f3f..87f6390 100644
--- a/versions/p-/pkgconf.json
+++ b/versions/p-/pkgconf.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "849c6b13074045c18f89394e7c7350efe8a630df",
+      "git-tree": "5b599bd7dbbbc7837f7dbcf1b111478da076e2a4",
       "version": "1.8.0",
       "port-version": 2
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d15470bb6464a3bb0ce3d98d118190cfd5189080 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/p-/pkgconf.json b/versions/p-/pkgconf.json
index 8277f3f..87f6390 100644
--- a/versions/p-/pkgconf.json
+++ b/versions/p-/pkgconf.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "849c6b13074045c18f89394e7c7350efe8a630df",
+      "git-tree": "5b599bd7dbbbc7837f7dbcf1b111478da076e2a4",
       "version": "1.8.0",
       "port-version": 2
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field can be found in the documentation

Neumann-A · 2022-02-12T05:43:09Z

@ras0219-msft why did you close this? This is not about colmap.

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field can be found in the documentation

JackBoosY · 2022-02-14T03:11:15Z

ninja: error: 'D:/installed/x64-windows-static/debug/lib/openblas.lib', needed by 'src/exe/colmap.exe', missing and no known rule to make it

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field can be found in the documentation

Neumann-A · 2022-02-14T09:53:12Z

@JackBoosY That is a bug in the dependency chain of colmap somewhere. Something is pulling in openblas if it is installed. Basically the repro is to first install openblas than everything colmap needs than deinstall openblas and retry to install colmap.

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/pkgconf/vcpkg.json

Valid values for the license field can be found in the documentation

strega-nil-ms · 2022-02-24T18:56:58Z

Thanks for your patience everyone!

* master: (57 commits) [vcpkg-tools] update cmake and git (windows only) (microsoft#22985) Update vcpkg tool to 2022-02-24. (microsoft#23162) [vcpkg baseline] Move cspice headers (microsoft#23272) Fixed inaccurate Chinese words (microsoft#23179) [vcpkg] Add fixed changelog generator. (microsoft#23255) [authentication.md] Add Jenkins section (microsoft#23226) [vcpkg] Meson osx sysroot (microsoft#21772) [pkgconf] enable search for system libs on linux (microsoft#23010) [yasm/yasm-tool] Incorporate yasm-tool into yasm (microsoft#23218) [lapack-reference] Update to 3.10 (microsoft#23228) [skia] Arm64 for skia on osx (microsoft#23222) [libfido2] Update to 1.10.0 (microsoft#23241) [Tracy] Fixing issue where version 0.7.8 was pulling the wrong version (microsoft#23061) [libgpiod] Add new port. (microsoft#23221) [drogon] Update to 1.7.5 (microsoft#23227) [tinyexif] Remove from fail list. (microsoft#23163) [vcpkg docs][ES] Sync with English readme (microsoft#19834) (microsoft#22618) [vcpkg baseline][libao] Disable dlfcn check under windows (microsoft#23235) [OpenCV] upgrade to v4.5.5 (microsoft#22801) [libcurl-simple-https] New port (microsoft#22917) ...

Neumann-A added 2 commits February 9, 2022 09:36

pkgconf enable system lookup on linux

f99cc6f

verison stuff

88a4ef2

Neumann-A mentioned this pull request Feb 9, 2022

[vcpkg-tools] update cmake and git (windows only) #22985

Merged

github-actions bot approved these changes Feb 9, 2022

View reviewed changes

JonLiu1993 assigned JackBoosY Feb 9, 2022

Neumann-A mentioned this pull request Feb 9, 2022

Update VMs for VS2022, CUDA 11.6 #23011

Merged

JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 9, 2022

strega-nil-ms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Feb 9, 2022

Neumann-A added 2 commits February 10, 2022 09:18

use ubuntu defaults.

bd963ed

version stuff

a775101

github-actions bot approved these changes Feb 10, 2022

View reviewed changes

This was referenced Feb 11, 2022

Sub target graclus has conflict with metis colmap/colmap#1421

Closed

[vcpkg baseline][colmap] Temporary skip colmap osx test #23047

Merged

WIP get libpaths from CMake

d83bd29

github-actions bot requested changes Feb 11, 2022

View reviewed changes

just get colmap trace for fun

6c53ec5

github-actions bot requested changes Feb 11, 2022

View reviewed changes

merge opensuse and ubuntu settings. should be good for most systems.

205728a

github-actions bot requested changes Feb 11, 2022

View reviewed changes

revert colmap change

aed632c

github-actions bot requested changes Feb 11, 2022

View reviewed changes

version stuff

86f921b

github-actions bot approved these changes Feb 11, 2022

View reviewed changes

ras0219-msft closed this in #23047 Feb 12, 2022

JackBoosY reopened this Feb 14, 2022

github-actions bot approved these changes Feb 14, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master' into HEAD

c639ee9

github-actions bot approved these changes Feb 14, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master' into HEAD

cae1c1e

github-actions bot approved these changes Feb 16, 2022

View reviewed changes

Neumann-A closed this Feb 17, 2022

Neumann-A reopened this Feb 17, 2022

github-actions bot approved these changes Feb 17, 2022

View reviewed changes

strega-nil-ms approved these changes Feb 24, 2022

View reviewed changes

strega-nil-ms merged commit 3f3efcc into microsoft:master Feb 24, 2022

Neumann-A deleted the pkgconf_system_libs branch February 24, 2022 19:29

dg0yt mentioned this pull request Mar 25, 2022

[wxwidgets] Fix linux build #23765

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pkgconf] enable search for system libs on linux #23010

[pkgconf] enable search for system libs on linux #23010

Neumann-A commented Feb 9, 2022 •

edited

Loading

github-actions bot left a comment

Neumann-A commented Feb 9, 2022

ras0219-msft commented Feb 9, 2022 •

edited

Loading

Neumann-A commented Feb 9, 2022

Neumann-A commented Feb 9, 2022 •

edited

Loading

dg0yt commented Feb 10, 2022 •

edited

Loading

Neumann-A commented Feb 10, 2022

dg0yt commented Feb 10, 2022

github-actions bot left a comment

JackBoosY commented Feb 10, 2022

dg0yt commented Feb 10, 2022

Neumann-A commented Feb 10, 2022

ras0219-msft commented Feb 10, 2022

Neumann-A commented Feb 10, 2022

Neumann-A commented Feb 10, 2022

JackBoosY commented Feb 11, 2022

github-actions bot left a comment

Neumann-A commented Feb 11, 2022

github-actions bot left a comment

Neumann-A commented Feb 11, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

Neumann-A commented Feb 12, 2022

github-actions bot left a comment

JackBoosY commented Feb 14, 2022

github-actions bot left a comment

Neumann-A commented Feb 14, 2022

github-actions bot left a comment

github-actions bot left a comment

strega-nil-ms commented Feb 24, 2022

[pkgconf] enable search for system libs on linux #23010

[pkgconf] enable search for system libs on linux #23010

Conversation

Neumann-A commented Feb 9, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

Neumann-A commented Feb 9, 2022

ras0219-msft commented Feb 9, 2022 • edited Loading

Neumann-A commented Feb 9, 2022

Neumann-A commented Feb 9, 2022 • edited Loading

dg0yt commented Feb 10, 2022 • edited Loading

Neumann-A commented Feb 10, 2022

dg0yt commented Feb 10, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Feb 10, 2022

dg0yt commented Feb 10, 2022

Neumann-A commented Feb 10, 2022

ras0219-msft commented Feb 10, 2022

Neumann-A commented Feb 10, 2022

Neumann-A commented Feb 10, 2022

JackBoosY commented Feb 11, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

Neumann-A commented Feb 11, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

Neumann-A commented Feb 11, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Neumann-A commented Feb 12, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Feb 14, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

Neumann-A commented Feb 14, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

strega-nil-ms commented Feb 24, 2022

Neumann-A commented Feb 9, 2022 •

edited

Loading

ras0219-msft commented Feb 9, 2022 •

edited

Loading

Neumann-A commented Feb 9, 2022 •

edited

Loading

dg0yt commented Feb 10, 2022 •

edited

Loading