Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yasm/yasm-tool] Incorporate yasm-tool into yasm #23218

Merged
merged 8 commits into from
Feb 24, 2022

Conversation

JackBoosY
Copy link
Contributor

Since port yasm and yasm-tool repo is same and generate the same files, remove port yasm-tool and switch the related dependency item yasm-tool to yasm.

Fixes #18746.

Replace #18816.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Feb 22, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gmp/vcpkg.json
  • ports/yasm-tool-helper/vcpkg.json
  • ports/yasm-tool/vcpkg.json
  • ports/yasm/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gmp/vcpkg.json
  • ports/yasm-tool-helper/vcpkg.json
  • ports/yasm-tool/vcpkg.json
  • ports/yasm/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gmp/vcpkg.json
  • ports/yasm-tool-helper/vcpkg.json
  • ports/yasm-tool/vcpkg.json
  • ports/yasm/vcpkg.json

Valid values for the license field can be found in the documentation

@JackBoosY
Copy link
Contributor Author

@BillyONeal I removed the script changes, please review again.

Thanks.

ports/yasm/portfile.cmake Show resolved Hide resolved
ports/yasm-tool/vcpkg.json Outdated Show resolved Hide resolved
ports/gmp/vcpkg.json Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gmp/vcpkg.json
  • ports/yasm-tool-helper/vcpkg.json
  • ports/yasm-tool/vcpkg.json
  • ports/yasm/vcpkg.json

Valid values for the license field can be found in the documentation

ports/yasm/portfile.cmake Show resolved Hide resolved
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Feb 24, 2022
@vicroms vicroms merged commit b7a1088 into microsoft:master Feb 24, 2022
@JackBoosY JackBoosY deleted the dev/jack/18816 branch February 25, 2022 02:20
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Feb 27, 2022
* master: (57 commits)
  [vcpkg-tools] update cmake and git (windows only) (microsoft#22985)
  Update vcpkg tool to 2022-02-24. (microsoft#23162)
  [vcpkg baseline] Move cspice headers (microsoft#23272)
  Fixed inaccurate Chinese words (microsoft#23179)
  [vcpkg] Add fixed changelog generator. (microsoft#23255)
  [authentication.md] Add Jenkins section (microsoft#23226)
  [vcpkg] Meson osx sysroot (microsoft#21772)
  [pkgconf] enable search for system libs on linux (microsoft#23010)
  [yasm/yasm-tool] Incorporate yasm-tool into yasm (microsoft#23218)
  [lapack-reference] Update to 3.10 (microsoft#23228)
  [skia] Arm64 for skia on osx (microsoft#23222)
  [libfido2] Update to 1.10.0 (microsoft#23241)
  [Tracy] Fixing issue where version 0.7.8 was pulling the wrong version (microsoft#23061)
  [libgpiod] Add new port. (microsoft#23221)
  [drogon] Update to 1.7.5 (microsoft#23227)
  [tinyexif] Remove from fail list. (microsoft#23163)
  [vcpkg docs][ES] Sync with English readme (microsoft#19834) (microsoft#22618)
  [vcpkg baseline][libao] Disable dlfcn check under windows (microsoft#23235)
  [OpenCV] upgrade to v4.5.5 (microsoft#22801)
  [libcurl-simple-https] New port (microsoft#22917)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yasm] Dependent library of yasm binary is missing
4 participants