Fix serialization issue with TestRunSettings #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use auto-property code-fix changed the readonly property into a private setter property which seems to change the behavior of the xml serializer. I have kept a property only but moved to a readonly property.
Evangelink
commented
Feb 2, 2022
| @@ -46,6 +45,7 @@ protected TestRunSettings(string name) | |||
| /// Converter the setting to be an XmlElement. | |||
| /// </summary> | |||
| /// <returns>The Xml element for the run settings provided.</returns> | |||
| [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes", Justification = "XmlElement is required in the data collector.")] | |||
There was a problem hiding this comment.
That's unrelated but I noticed this was removed during the reformatting and should not have been.
nohwnd
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use auto-property code-fix changed the readonly property into a private setter property which seems to change the behavior of the xml serializer. I have kept a property only but moved to a readonly property.
cc @AbhitejJohn