Fix serialization issue with TestRunSettings

src/Microsoft.TestPlatform.ObjectModel/RunSettings/TestRunSettings.cs

@@ -12,7 +12,6 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel;
 /// </summary>
 public abstract class TestRunSettings
 {
-
     #region Constructor
 
     /// <summary>
@@ -37,7 +36,7 @@ protected TestRunSettings(string name)
     /// during RunSettings.LoadSection() call
     /// TODO: Communicate to Chutzpah and fix it
     /// </summary>
-    public string Name { get; private set; }
+    public string Name { get; }
 
     #endregion
 
@@ -46,6 +45,7 @@ protected TestRunSettings(string name)
     /// Converter the setting to be an XmlElement.
     /// </summary>
     /// <returns>The Xml element for the run settings provided.</returns>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes", Justification = "XmlElement is required in the data collector.")]
     public abstract XmlElement ToXml();
 #endif
 }

test/Microsoft.TestPlatform.ObjectModel.UnitTests/RunSettings/RunSettingsTests.cs

@@ -0,0 +1,40 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Microsoft.TestPlatform.ObjectModel.UnitTests;
+
+using System.IO;
+using System.Xml;
+using System.Xml.Serialization;
+
+using Microsoft.VisualStudio.TestPlatform.ObjectModel;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+[TestClass]
+public class RunSettingsTests
+{
+    [TestMethod]
+    public void RunSettingsNameSerialization()
+    {
+        var chilRunSettings = new ChildRunSettings();
+        var xml = chilRunSettings.ToXml();
+        Assert.IsNotNull(xml);
+    }
+
+    public class ChildRunSettings : TestRunSettings
+    {
+        public ChildRunSettings() : base("SomeName")
+        {
+        }
+
+        public override XmlElement ToXml()
+        {
+            var document = new XmlDocument();
+            using (XmlWriter writer = document.CreateNavigator().AppendChild())
+            {
+                new XmlSerializer(typeof(ChildRunSettings)).Serialize(writer, this);
+            }
+            return document.DocumentElement;
+        }
+    }
+}