Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable animation for login page #2777

Closed
wants to merge 3 commits into from

Conversation

cgpoh
Copy link

@cgpoh cgpoh commented Apr 14, 2023

Following @dvaldivia to disable animation for login page until kubernetes/kubectl#1368 get resolved

@dvaldivia
Copy link
Collaborator

I don't think we should disable the animation on the console itself, since it's expected to expose the console via ingress or similar, for the operator UI perhaps not everyone will want to expose it so I deem it necessary to disable the animation, perhaps for Console if we really need this we should disable it via environment variable

@cgpoh
Copy link
Author

cgpoh commented Apr 14, 2023

Thanks for the comment. We can’t use ingress due to security reason and we can only use port forward to login to minio console. I will try to use environment variable to allow turning on/off the animation.

@dnskr
Copy link

dnskr commented Apr 25, 2023

Could someone review this please?

@bexsoft
Copy link
Collaborator

bexsoft commented May 3, 2023

Hi @cgpoh!, Thank you for your contribution

For this behavior to work, we will need some changes in MinIO as we don't support the ability to modify JS files directly into the server. We have created this PR that will help to achieve this behavior: #2799 using env variables directly that can be read & managed directly from MinIO

We will be implementing the required change in MinIO as well. We will be closing this PR, Please feel free to reopen in case you think something is missing

@bexsoft bexsoft closed this May 3, 2023
@cgpoh
Copy link
Author

cgpoh commented May 3, 2023

Hi @cgpoh!, Thank you for your contribution

For this behavior to work, we will need some changes in MinIO as we don't support the ability to modify JS files directly into the server. We have created this PR that will help to achieve this behavior: #2799 using env variables directly that can be read & managed directly from MinIO

We will be implementing the required change in MinIO as well. We will be closing this PR, Please feel free to reopen in case you think something is missing

Hi @bexsoft , thanks for your help!

@cgpoh cgpoh deleted the disable-animation branch May 3, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants