-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Disable login animation with env variable #2799
Conversation
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested .
CONSOLE_ANIMATED_LOGIN=off
- Static image is used
CONSOLE_ANIMATED_LOGIN=on
- Animation is used. ( default )
Changes look good to me 👍
Tested, LTGM. Default is enabled. |
Was wondering if we could add some docs to know how to use it and the available values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added some provisional docs in Console Wiki page (https://github.com/minio/console/wiki/Disable-Login-Animation-using-env-vars), some extra information should be added in official documentation once this is implemented in MinIO server |
Awesome @ravindk89 @djwfyi, Thank you!, Will check with @cniackz on the Github action to auto-generate this tickets |
This will get added to the docs as part of minio/docs#845. |
What does this do?
Added an env variable to disable animation in Console. For this to work we need to make another change in MinIO repo to support this behavior from MinIO's binary
How to test
make assets build
in console's root folder./console server
http://localhost:9090/login
To test animated background just delete the env variable or set it to
on