Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Disable login animation with env variable #2799

Merged
merged 2 commits into from
May 3, 2023

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented May 3, 2023

What does this do?

Added an env variable to disable animation in Console. For this to work we need to make another change in MinIO repo to support this behavior from MinIO's binary

How to test

  1. Do make assets build in console's root folder
  2. Set the following env variables:
CONSOLE_ACCESS_KEY=<your_root_access_key>
CONSOLE_SECRET_KEY=<your_root_secret_key>
CONSOLE_MINIO_SERVER=<your_minio_server_url>
CONSOLE_ANIMATED_LOGIN=off
  1. Start console by running ./console server
  2. Open your web browser and open http://localhost:9090/login

To test animated background just delete the env variable or set it to on

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft bexsoft self-assigned this May 3, 2023
@bexsoft bexsoft changed the title Added Disable login animation anv variable Added Disable login animation with env variable May 3, 2023
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested .
CONSOLE_ANIMATED_LOGIN=off - Static image is used
CONSOLE_ANIMATED_LOGIN=on - Animation is used. ( default )

Changes look good to me 👍

@ravindk89 ravindk89 added the docs-needed For tying into future githook to create issue in minio/docs label May 3, 2023
@cesnietor
Copy link
Collaborator

Tested, LTGM. Default is enabled.

@cesnietor
Copy link
Collaborator

Was wondering if we could add some docs to know how to use it and the available values.

Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft
Copy link
Collaborator Author

bexsoft commented May 3, 2023

Was wondering if we could add some docs to know how to use it and the available values.

Added some provisional docs in Console Wiki page (https://github.com/minio/console/wiki/Disable-Login-Animation-using-env-vars), some extra information should be added in official documentation once this is implemented in MinIO server

@bexsoft bexsoft merged commit cde6d1b into minio:master May 3, 2023
@bexsoft bexsoft deleted the disable-animation branch May 3, 2023 17:36
@ravindk89
Copy link
Contributor

@bexsoft we (well, @djwfyi ) manually scans new releases and adds those features to our queue.

If we can get a github action set up to auto-open an issue in our repo it gets a little easier to track. Either way we'll get to it after release.

@bexsoft
Copy link
Collaborator Author

bexsoft commented May 3, 2023

@bexsoft we (well, @djwfyi ) manually scans new releases and adds those features to our queue.

If we can get a github action set up to auto-open an issue in our repo it gets a little easier to track. Either way we'll get to it after release.

Awesome @ravindk89 @djwfyi, Thank you!, Will check with @cniackz on the Github action to auto-generate this tickets

@djwfyi
Copy link
Contributor

djwfyi commented May 5, 2023

This will get added to the docs as part of minio/docs#845.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-needed For tying into future githook to create issue in minio/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants