Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minio rejects valid hostnames #760

Closed
dwhitlow opened this issue May 10, 2019 · 1 comment · Fixed by #761
Closed

Minio rejects valid hostnames #760

dwhitlow opened this issue May 10, 2019 · 1 comment · Fixed by #761

Comments

@dwhitlow
Copy link

dwhitlow commented May 10, 2019

The Minio python library rejects hostnames with underscores in them. Since this is a standard separator for docker container names, this causes problems when trying to run Minio as part of a docker compose setup.

For example, with a linked container named minio_server, this python session should not raise an error:

Python 3.6.8 (default, Mar 27 2019, 08:53:45) 
[GCC 6.3.0 20170516] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from minio import Minio
>>> Minio('minio_server:9000')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/site-packages/minio/api.py", line 147, in __init__
    is_valid_endpoint(endpoint)
  File "/usr/local/lib/python3.6/site-packages/minio/helpers.py", line 299, in is_valid_endpoint
    raise InvalidEndpointError('Hostname does not meet URL standards.')
minio.error.InvalidEndpointError: InvalidEndpointError: message: Hostname does not meet URL standards.
@kannappanr
Copy link
Collaborator

@dwhitlow Thanks for filing this issue. We will take a look at it.

Praveenrajmani added a commit to Praveenrajmani/minio-py that referenced this issue May 14, 2019
For eg, `minio_server` should be treated as valid hostnames.

Fixes minio#760
Praveenrajmani added a commit to Praveenrajmani/minio-py that referenced this issue May 15, 2019
For eg, `minio_server` should be treated as valid hostname.

Fixes minio#760
Praveenrajmani added a commit to Praveenrajmani/minio-py that referenced this issue May 15, 2019
For eg, `minio_server` should be treated as valid hostname.

Fixes minio#760
Praveenrajmani added a commit to Praveenrajmani/minio-py that referenced this issue May 15, 2019
For eg, `minio_server` should be treated as valid hostname.

Fixes minio#760
Praveenrajmani added a commit to Praveenrajmani/minio-py that referenced this issue May 15, 2019
For eg, `minio_server` should be treated as valid hostname.

Fixes minio#760
nitisht pushed a commit that referenced this issue May 16, 2019
For eg, `minio_server` should be treated as valid hostname.

Fixes #760
@nitisht nitisht added fixed and removed triage labels May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants