Validate underscores in host names successfully #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
previously approved these changes
May 14, 2019
|
@Praveenrajmani Please fix the Appveyor build failures |
|
looks like an installation failure. will push again @kannappanr |
Praveenrajmani
force-pushed
the
regex-hostname
branch
3 times, most recently
from
8725990
to
412836d
Compare
For eg, `minio_server` should be treated as valid hostname. Fixes minio#760
Praveenrajmani
force-pushed
the
regex-hostname
branch
from
412836d
to
2d7129b
Compare
|
ping @nitisht |
nitisht
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For eg,
minio_servershould be treated as valid hostnames.Fixes #760