MRG: In BIDSPath, don't infer the datatype from the suffix #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
force-pushed
the
be-less-clever
branch
3 times, most recently
from
6ebf4d0
to
2fe2b3e
Compare
I needed to set datatype to None to make `find_emptyroom()` deal with the inheritance principle correctly, but turns out it never took effect because `BIDSPath.update()` would silently replace my `datatype=None` with an inferred `datatype='meg'`.
hoechenberger
force-pushed
the
be-less-clever
branch
from
2fe2b3e
to
d812b2a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1030 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 25 25
Lines 3777 3778 +1
=======================================
+ Hits 3595 3596 +1
Misses 182 182
Help us with your feedback. Take ten seconds to tell us how you rate us. |
hoechenberger
changed the title
|
This PR is a blocker for mne-tools/mne-bids-pipeline#576 |
hoechenberger
changed the title
hoechenberger
commented
Jul 30, 2022
hoechenberger
commented
Jul 30, 2022
| @@ -1237,14 +1233,15 @@ def _parse_ext(raw_fname): | |||
| return fname, ext | |||
|
|
|||
|
|
|||
| def _infer_datatype_from_path(fname): | |||
| def _infer_datatype_from_path(fname: Path): | |||
There was a problem hiding this comment.
this function is used by get_bids_path_from_fname()
IMHO it's doing too much magic too, but here I only ensured it keeps on working
agramfort
approved these changes
Jul 30, 2022
|
Thanks @hoechenberger |
2 tasks
sappelhoff
added a commit
that referenced
this pull request
Aug 26, 2022
) * Updated the BIDSPath in-place update example I updated the `BIDSPath` in-place update example to perhaps make it clearer to users what in-place updating means. It's a small change, but should make the message clearer. * Missing printout in BIDSPath example and indentation * Remove additional tab at EOL * Added datatype to BIDSPath update after #1030 Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Added BHV name to CITATION.cff Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to set datatype to None to make
find_emptyroom()deal with the inheritance principle correctly, but turns out it never took effect becauseBIDSPath.update()would silently replace mydatatype=Nonewith an inferreddatatype='meg'.This PR stops this automated inference.
This will likely break user code, but it's the right thing to do as we've been trying to be too clever in the past.
Merge checklist
Maintainer, please confirm the following before merging: