Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: In BIDSPath, don't infer the datatype from the suffix #1030

Merged
merged 2 commits into from
Jul 30, 2022
Merged

MRG: In BIDSPath, don't infer the datatype from the suffix #1030

merged 2 commits into from
Jul 30, 2022

Commits on Jul 30, 2022

  1. In BIDSPath.update(), don't infer the datatype from the suffix 

    I needed to set datatype to None to make `find_emptyroom()`
deal with the inheritance principle correctly, but turns out it
never took effect because `BIDSPath.update()` would silently
replace my `datatype=None` with an inferred `datatype='meg'`.
    @hoechenberger
    hoechenberger committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    d812b2a View commit details
    Browse the repository at this point in the history

  2. Update doc/whats_new.rst

    @hoechenberger
    hoechenberger committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    feede17 View commit details
    Browse the repository at this point in the history