-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run unit tests on Apple Silicon and bump Node version to LTS (currently 20) #1231
Conversation
blocked by #1233 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
- Coverage 97.61% 97.59% -0.02%
==========================================
Files 40 40
Lines 8685 8663 -22
==========================================
- Hits 8478 8455 -23
- Misses 207 208 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
@sappelhoff I will take care of the failing CI job |
@sappelhoff I think you merged a failing branch :) I'll open a follow-up PR to fix this |
urgs, sorry. |
No worries, happens … I think it got auto-merged because the new CI job had naturally not been added to the branch protection rules yet! |
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: