Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests on Apple Silicon and bump Node version to LTS (currently 20) #1231

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Run unit tests on Apple Silicon and bump Node version to LTS (currently 20) #1231

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94b6471
Run unit tests on Apple Silicon and bump Node version to LTS (current…
hoechenberger Mar 4, 2024
66f5d43
Update unit_tests.yml
hoechenberger Mar 4, 2024
2b619a3
Merge branch 'main' into tests
sappelhoff Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ jobs:

test:
# For GitHub "required" CI checks, add in branch protection:
# 6 checks:
# for each OS (ubuntu, macos, windows):
# 7 checks:
# for each OS (ubuntu, macos, macos-14 windows):
hoechenberger marked this conversation as resolved.
Show resolved Hide resolved
# 3.9 -> stable / full / stable
# 3.12 -> stable / full / stable
#
Expand All @@ -125,7 +125,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, macos-latest, macos-14, windows-latest] # macos-14 is Apple Silicon
python-version: ["3.9", "3.12"] # Oldest and newest supported versions
mne-version: [mne-stable]
mne-bids-install: [full]
Expand Down Expand Up @@ -162,7 +162,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
Expand Down
Loading