Refactor test_epochs.py::test_split_saving (2 out of 2) #11884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
[skip ci]
[skip ci]
We don't need split size or n_files here [skip ci]
dmalt
changed the title
dmalt
force-pushed
the
refactor-epochs-splits-naming-test-2
branch
from
f325dd5
to
4764a17
Compare
[skip ci]
dmalt
force-pushed
the
refactor-epochs-splits-naming-test-2
branch
from
38da5c5
to
2559126
Compare
for more information, see https://pre-commit.ci [skip ci]
Recently added check for the number of saved files in test_split_naming, fails on Windows: the amount of splits on Windows differs from expected. Reduce the number of epochs to make this test pass. [skip ci]
Instead of saving epochs to create existing file, use `touch()`; this gives finer control over corner cases. Use parametrization to cover these cases. N.B.: apparently there's a bug. [ci skip]
dmalt
force-pushed
the
refactor-epochs-splits-naming-test-2
branch
from
180d91e
to
cde329b
Compare
|
Ready for review as soon as the tests pass. |
for more information, see https://pre-commit.ci
[skip ci]
dmalt
force-pushed
the
refactor-epochs-splits-naming-test-2
branch
from
314c742
to
d0bc779
Compare
larsoner
approved these changes
Aug 16, 2023
auto-merge was automatically disabled
August 16, 2023 16:46
Head branch was pushed to by a user without write access
Great, thanks!
Looks like it worked. |
auto-merge was automatically disabled
August 16, 2023 17:56
Head branch was pushed to by a user without write access
|
@larsoner looks like |
|
Thanks @dmalt ! |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Aug 16, 2023
* upstream/main: Refactor test_epochs.py::test_split_saving (2 out of 2) (mne-tools#11884) Cross-figure event passing system (mne-tools#11685)
larsoner
added a commit
to drammock/mne-python
that referenced
this pull request
Aug 22, 2023
* upstream/main: [pre-commit.ci] pre-commit autoupdate (mne-tools#11911) [BUG, MRG] Remove check on `mne.viz.Brain.add_volume_labels` (mne-tools#11889) Small splits fix (mne-tools#11905) adds niseq package to "Related software" (mne-tools#11909) Minor fixes for ERDS maps example (mne-tools#11904) FIX: Fix pyvista rendering (mne-tools#11896) BUG: Fix epoch splits naming (mne-tools#11876) ENH: Use section-title for HTML anchors in Report (mne-tools#11890) CI: Deploy [circle deploy] MAINT: Clean up whats_new and doc versions (mne-tools#11888) Refactor test_epochs.py::test_split_saving (2 out of 2) (mne-tools#11884) Cross-figure event passing system (mne-tools#11685) MAINT: Post-release deprecations, updates [circle deploy] (mne-tools#11887) MAINT: Release 1.5.0 (mne-tools#11886) [pre-commit.ci] pre-commit autoupdate (mne-tools#11883) Refactor test_epochs.py::test_split_saving (1 out of 2) (mne-tools#11880) FIX: Missing Saccade information in Eyelink File (mne-tools#11877) Improve drawing of annotations with matplotlib (mne-tools#11855) MAINT: Work around NumPy deprecation (mne-tools#11878)
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #11880
Leg work to fix #11870.