Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small splits fix #11905

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Small splits fix #11905

merged 3 commits into from
Aug 22, 2023

Conversation

dmalt
Copy link
Contributor

@dmalt dmalt commented Aug 19, 2023

  • a small follow-up indexing simplification when creating bids split fnames.
  • a small fix to a docstring.
  • check writing over a split when saving raw also for neuromag schema (we did the same fix for epochs earlier)

@dmalt dmalt marked this pull request as draft August 19, 2023 08:47
@dmalt dmalt changed the title Small refactor Small splits fix Aug 19, 2023
@dmalt dmalt marked this pull request as ready for review August 19, 2023 11:04
@larsoner larsoner merged commit 1ee3270 into mne-tools:main Aug 22, 2023
26 checks passed
@larsoner
Copy link
Member

Thanks @dmalt !

larsoner added a commit to larsoner/mne-python that referenced this pull request Aug 22, 2023
* upstream/main:
  Small splits fix (mne-tools#11905)
  adds niseq package to "Related software" (mne-tools#11909)
  Minor fixes for ERDS maps example (mne-tools#11904)
larsoner added a commit to drammock/mne-python that referenced this pull request Aug 22, 2023
* upstream/main:
  [pre-commit.ci] pre-commit autoupdate (mne-tools#11911)
  [BUG, MRG] Remove check on `mne.viz.Brain.add_volume_labels` (mne-tools#11889)
  Small splits fix (mne-tools#11905)
  adds niseq package to "Related software" (mne-tools#11909)
  Minor fixes for ERDS maps example (mne-tools#11904)
  FIX: Fix pyvista rendering (mne-tools#11896)
  BUG: Fix epoch splits naming (mne-tools#11876)
  ENH: Use section-title for HTML anchors in Report (mne-tools#11890)
  CI: Deploy [circle deploy]
  MAINT: Clean up whats_new and doc versions (mne-tools#11888)
  Refactor test_epochs.py::test_split_saving (2 out of 2) (mne-tools#11884)
  Cross-figure event passing system (mne-tools#11685)
  MAINT: Post-release deprecations, updates [circle deploy] (mne-tools#11887)
  MAINT: Release 1.5.0 (mne-tools#11886)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#11883)
  Refactor test_epochs.py::test_split_saving (1 out of 2) (mne-tools#11880)
  FIX: Missing Saccade information in Eyelink File (mne-tools#11877)
  Improve drawing of annotations with matplotlib (mne-tools#11855)
  MAINT: Work around NumPy deprecation (mne-tools#11878)
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants