Add proto definitions to support tunneled sandboxes #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawalt
force-pushed
the
pawalt/sandbox_tunnels
branch
4 times, most recently
from
49f0594
to
6eb9902
Compare
This commit adds proto definitions that allow sandboxes to be created with open ports specified. It also adds an RPC definition for getting the tunnels once established.
pawalt
force-pushed
the
pawalt/sandbox_tunnels
branch
from
6eb9902
to
409000a
Compare
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
|
@prbot help a brother out |
| } | ||
|
|
||
| message SandboxGetTunnelsResponse { | ||
| repeated TunnelData tunnels = 1; |
There was a problem hiding this comment.
With this response how do you indicate "no tunnels, stop polling" vs "no tunnels yet"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This commit adds proto definitions that allow sandboxes to be created with open ports specified. It also adds an RPC definition for getting the tunnels once established.
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog