Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenericResult to sandbox tunnels response #2171

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

pawalt
Copy link
Member

@pawalt pawalt commented Aug 30, 2024

Describe your changes

This allows us to know if the SandboxGetTunnels RPC returned because of a timeout or full data.

Backward/forward compatibility checks
  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

This is not a backwards-compatible proto change, but it's OK because there's no code (and there will be no code) that uses the old version.


Changelog

This allows us to know if the SandboxGetTunnels RPC returned because of
a timeout or full data.
@pawalt
Copy link
Member Author

pawalt commented Aug 30, 2024

@prbot approve

@pawalt
Copy link
Member Author

pawalt commented Aug 30, 2024

@prbot automerge

@pawalt pawalt merged commit 0440ad6 into main Aug 30, 2024
23 checks passed
@pawalt pawalt deleted the pawalt/sandbox_result branch August 30, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants