This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Resolve label metrics are _other_ and add legacy client id #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dexterp37 Please help review. I am also interested if our #3129 issue would be resolved after we did a Glean update. Is there a way to verify or add a test for it? |
Dexterp37
suggested changes
May 16, 2020
Yes, it received some fixes after v25 (see the changelog). |
Dexterp37
approved these changes
May 18, 2020
|
@daoshengmu are you planning on merging this soon? |
|
Fixes #3129 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3212 and #3324.
In #3212, our labels should be converted to lower case, and add legacy client id in deletion request ping for #3324.