[PickersCalendarSkeleton] Rename to CalendarPickerSkeleton #25679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
breaking change
component: pickers
eps1lon
force-pushed
the
feat/rename-calendars-picker-skeleton
branch
from
48de94d
to
6a7e422
Compare
This reverts commit 0ad2b1a. We need a smarter approach. This caused all translations to be invalidated.
eps1lon
force-pushed
the
feat/rename-calendars-picker-skeleton
branch
from
6a7e422
to
2f5d7ac
Compare
oliviertassinari
approved these changes
Apr 10, 2021
| @@ -1252,6 +1257,38 @@ function generateApiPagesManifest(outputPath: string, prettierConfigPath: string | |||
| writePrettifiedFile(outputPath, source, prettierConfigPath); | |||
| } | |||
|
|
|||
| async function removeOutdatedApiDocsTranslations(components: ReactApi[]): Promise<void> { | |||
There was a problem hiding this comment.
I guess we will merge #25680 first
|
Will merge after todays release. This change only makes sense with #25685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Based on #25680 (diff)
In preparation of https://github.com/mui-org/material-ui/issues/25481 where want to rename
DayPickertoCalendarPicker.The new name makes the relation to
CalendarPickermore obvious.Discovered that we don't cleanup api-docs so I'll do that separately.