[Pickers] Rename date view to day
#25685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
breaking change
component: pickers
eps1lon
force-pushed
the
feat/rename-date-view
branch
from
090ccdb
to
3e8de72
Compare
eps1lon
commented
Apr 9, 2021
| type TabValue = 'date' | 'time'; | ||
|
|
||
| const viewToTab = (openView: DateTimePickerView): TabValue => { | ||
| // TODO: what happens if `openView` is `month`? |
There was a problem hiding this comment.
This refactoring revealed accidental coupling with the DateTimePickerTabs they handle clock and calendar view switch not the DateTimePickerView switch. Will revisit this when renaming DayPicker to CalendarPicker where TabValue might become 'clock' | 'calendar'.
eps1lon
commented
Apr 9, 2021
| @@ -28,7 +28,7 @@ interface DesktopDateRangeCalendarProps<TDate> | |||
| changeMonth: (date: TDate) => void; | |||
| } | |||
|
|
|||
| const onlyDateView = ['date'] as ['date']; | |||
| const onlyDayView = ['day'] as ['day']; | |||
There was a problem hiding this comment.
Should be
Suggested change
| const onlyDayView = ['day'] as ['day']; | |
| const onlyDayView = ['day'] as const; |
but most of our typings conflict with readonly arrays. We should change all T[] props to readonly T[] props at some point to ensure compat with as const casts i.e. apply #24639 consistently.
eps1lon
force-pushed
the
feat/rename-date-view
branch
from
3e8de72
to
5fa9a40
Compare
eps1lon
force-pushed
the
feat/rename-date-view
branch
from
5fa9a40
to
4c647f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Part of https://github.com/mui-org/material-ui/issues/25481
Based on #25679 (diff).
Right now we have the
DatePickerwhich has theyear,monthanddateview. That's a bit confusing sincedateis already part of the component name whendaterefers to a particular day.This PR creates another conflict with the
DayPickercomponent which doesn't actually pick a day but a date. So we're going to renameDayPickertoCalendarPickerto completely entangle this confusion. Will add this in another PR though for proper changelog attention.