-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize Python support #35
Comments
Yes I agree. Just a few more points to add. With poetry the minimum python version supported is defined here: The CI for this library uses 3.10 for build and test: Also, very supportive of removing code that is no longer necessary as we upgrade the python version. |
@frankinspace, thanks for the follow up on the issues I recently created. I fully intend to submit PRs for them all (unless someone beats me to them). I'm going to start with this one since I think it's perhaps the most fundamental one to address. |
- Refactor code accommodating old urllib package structure - Add CI testing for Python 3.8 through 3.12 - Automate updating GitHub Actions versions - Fix all flake8 warnings Fixes nasa#35
* Modernize Python support - Refactor code accommodating old urllib package structure - Add CI testing for Python 3.8 through 3.12 - Automate updating GitHub Actions versions - Fix all flake8 warnings Fixes #35 * Upgrade flake8 * Remove caching of Poetry install It is unclear why the CI build fails to find `poetry` even after the step that runs `pipx ensurepath`, particularly because locally running the workflow via `act` succeeds. Removing the use of a cache for the poetry installation itself, so that poetry is always freshly installed, and thus should always be found on the path. * Add badges to README.md * Rename unit test workflow to Tests --------- Co-authored-by: Frank Greguska <89428916+frankinspace@users.noreply.github.com>
Many versions of Python have been released (and many have become unsupported) since this repo was first created, and there are at least a couple of places where I've noticed either an unspecified minimum required Python version, or code that is meant to accommodate some very old Python versions.
For example, the
classifiers
block inpyproject.toml
does not list any specific Python versions. I suggest this block be updated appropriately, including a minimum no less than Python 3.8. In fact, the GitHub Actions workflows use only 3.10 or later, so these should likely also be enhanced to perform a matrix of tests across all versions of Python this library is intended to work with (perhaps 3.8 through 3.12, with 3.13 to follow soon).One place in the code attempts to accommodate a very old package structure for urllib functionality that should be simplified/unified. There may be other places that should be modernized, but maybe not. The codebase is relatively small, but I haven't looked for other spots yet.
The text was updated successfully, but these errors were encountered: