Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #36

Closed
chuckwondo opened this issue Apr 18, 2024 · 1 comment · Fixed by #44
Closed

Add type annotations #36

chuckwondo opened this issue Apr 18, 2024 · 1 comment · Fixed by #44
Labels
enhancement New feature or request

Comments

@chuckwondo
Copy link
Collaborator

Arguably, type annotations are extremely helpful and have become quite common, either directly within Python libraries, or within type stub packages (such as those available on typeshed).

Since typing was introduced in Python 3.5 (IIRC), adding type annotations should likely be done after #35 is implemented, so that it is clear that this library supports only versions of Python no older than 3.5 (although likely no older than 3.8, as 3.8 is even close to "retirement").

The motivation here is not only as part of "modernizing" this library, but also because the lack of type annotations here has led to defining type stubs for this library within the earthaccess library, which uses this library. See nsidc/earthaccess#508. I would like to use those type stubs as a basis for implementing a solution to this issue.

@frankinspace frankinspace added the enhancement New feature or request label Apr 18, 2024
@frankinspace
Copy link
Collaborator

Yes, big supporter of type annotations

chuckwondo added a commit to chuckwondo/python_cmr that referenced this issue Apr 23, 2024
frankinspace pushed a commit that referenced this issue Apr 23, 2024
This was referenced Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants