Fix for https://github.com/near/near-cli/issues/786 #913
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎤 ✔️ 12... |
|
Any feedback on this one? |
|
@volovyk-s |
volovyks
reviewed
May 30, 2022
| @@ -9,6 +9,10 @@ module.exports = { | |||
| .option('yolo', { | |||
| description: 'Do not ask for extra confirmation when using Ledger', | |||
| type: 'boolean', | |||
| }) | |||
There was a problem hiding this comment.
This option is already available on the top level. We should not add it here again.
| @@ -36,7 +40,7 @@ module.exports = { | |||
|
|
|||
| const { deps: { keyStore } } = near.config; | |||
| const existingKey = await keyStore.getKey(argv.networkId, argv.accountId); | |||
| if (existingKey) { | |||
| if (existingKey && !argv.seedPhrase) { | |||
There was a problem hiding this comment.
It will fix just 1 out of ~5 problems we have with generation keys. This is a critical please of code, so I would prefer to fix them all at once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the seed phrase is used on the command line regardless of position, the seed-phrase middleware creates a key and adds it to the keystore. This change considers that fact and eliminates output of the confusing message.
Also added the seedPhrase yargs option as it seems to be supported per how things work and even per the comment here:
near-cli/middleware/seed-phrase.js
Line 8 in 63cd30c