Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable http2 for now due to Qt bug #1806

Closed
wants to merge 1 commit into from
Closed

Disable http2 for now due to Qt bug #1806

wants to merge 1 commit into from

Conversation

Milokita
Copy link
Contributor

So that user may continue to use http2 on their webpage

Signed-off-by: XNG Milokita@users.noreply.github.com

  So that user may continue to use http2 on their webpage

Signed-off-by: XNG <Milokita@users.noreply.github.com>
@Milokita Milokita requested a review from misch7 March 2, 2020 00:45
misch7 added a commit that referenced this pull request Mar 2, 2020
… var (upstream)

Disable http2 for now due to Qt bug but allow enabling it via env var, see: owncloud/client#7620
  and: #1806
Issue: #1503

Co-authored-by: XNG <Milokita@users.noreply.github.com>
Co-authored-by: Hannah von Reth <hannah.vonreth@owncloud.com>

Signed-off-by: Michael Schuster <michael@schuster.ms>
Copy link
Member

@misch7 misch7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to reintroduce the #if to fix the Drone build (and older Qt builds).

I opened a new PR #1823 to push the changes, thank you for your initiative! :-) 👍

@misch7 misch7 closed this Mar 2, 2020
backportbot-nextcloud bot pushed a commit that referenced this pull request Mar 2, 2020
… var (upstream)

Disable http2 for now due to Qt bug but allow enabling it via env var, see: owncloud/client#7620
  and: #1806
Issue: #1503

Co-authored-by: XNG <Milokita@users.noreply.github.com>
Co-authored-by: Hannah von Reth <hannah.vonreth@owncloud.com>

Signed-off-by: Michael Schuster <michael@schuster.ms>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants