Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HTTP/2 for now due to Qt bug, allow enabling it via env var #1823

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

misch7
Copy link
Member

@misch7 misch7 commented Mar 2, 2020

Disable HTTP/2 for now due to Qt bug but allow enabling it via env var,
see: owncloud/client#7620 and: #1806

Issue: #1503

The build had to be fixed for older Qt versions, so this PR supersedes #1806 to reintroduce the #if.

Milokita and others added 2 commits March 2, 2020 01:27
  So that user may continue to use http2 on their webpage

Signed-off-by: XNG <Milokita@users.noreply.github.com>
(cherry picked from commit dad95d4)
Signed-off-by: Michael Schuster <michael@schuster.ms>
… var (upstream)

Disable http2 for now due to Qt bug but allow enabling it via env var, see: owncloud/client#7620
  and: #1806
Issue: #1503

Co-authored-by: XNG <Milokita@users.noreply.github.com>
Co-authored-by: Hannah von Reth <hannah.vonreth@owncloud.com>

Signed-off-by: Michael Schuster <michael@schuster.ms>
@misch7 misch7 requested a review from Milokita March 2, 2020 01:03
@misch7 misch7 self-assigned this Mar 2, 2020
@misch7 misch7 added this to the 2.6.4 milestone Mar 2, 2020
@misch7 misch7 merged commit 7fa44d4 into master Mar 2, 2020
@misch7 misch7 deleted the fix-http2-disable branch March 2, 2020 02:26
@misch7
Copy link
Member Author

misch7 commented Mar 2, 2020

/backport to stable-2.6

@backportbot-nextcloud
Copy link

backport to stable-2.6 in #1825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants