Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding blurhash to definitions #47331

Merged

Conversation

skalidindi53
Copy link

@skalidindi53 skalidindi53 commented Aug 19, 2024

Summary

  • Added blurhash to RichObjectString definitions

Checklist

@skalidindi53 skalidindi53 added the 2. developing Work in progress label Aug 19, 2024
@skalidindi53 skalidindi53 self-assigned this Aug 19, 2024
@skalidindi53 skalidindi53 force-pushed the skalidindi53/12351/Add-blurhash-to-richobjectstrings branch 3 times, most recently from b714a6f to 2aa64df Compare August 19, 2024 16:52
@skalidindi53 skalidindi53 marked this pull request as draft August 19, 2024 16:53
@provokateurin
Copy link
Member

Thanks for the PR, please make sure it is based on the latest master state and then do a composer i and ./build/openapi-checker.sh. That should remove all the unintended OpenAPI changes.

@provokateurin
Copy link
Member

Also the changes in lib/composer have to be reverted

@provokateurin
Copy link
Member

Ah I see what is going on, the lockfiles in vendor-bin have been changed and that is causing the OpenAPI changes. So please remove all changes except for lib/public.

@skalidindi53 skalidindi53 force-pushed the skalidindi53/12351/Add-blurhash-to-richobjectstrings branch 2 times, most recently from 6f0a804 to 2ec43d1 Compare August 19, 2024 18:49
Signed-off-by: skalidindi53 <s.teja2004@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the skalidindi53/12351/Add-blurhash-to-richobjectstrings branch from 2ec43d1 to 3a67168 Compare August 20, 2024 06:25
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted all unrelated parts

@nickvergessen
Copy link
Member

/backport to stable30

@nickvergessen nickvergessen marked this pull request as ready for review August 20, 2024 10:11
@nickvergessen nickvergessen merged commit 7fe62b9 into master Aug 21, 2024
175 checks passed
Copy link

welcome bot commented Aug 21, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@nickvergessen nickvergessen deleted the skalidindi53/12351/Add-blurhash-to-richobjectstrings branch August 21, 2024 09:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants