-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added blurhash to image metadata #13009
feat: Added blurhash to image metadata #13009
Conversation
aa74c4f
to
5e811e0
Compare
5e811e0
to
52955da
Compare
Signed-off-by: skalidindi53 <s.teja2004@gmail.com>
e351992
to
6d5fb17
Compare
Signed-off-by: skalidindi53 <s.teja2004@gmail.com>
@SystemKeeper can/want to give this a try? |
/backport to stable30 |
The PR works fine for me and correctly returns the blurhash. Would it make sense to rename size-related methods/variables like One thing I noticed is that blurhash generation has since been moved to a background job: https://github.com/nextcloud/server/blob/560282a47bf3f9dca4653f89d530a6e1dd144f5f/lib/private/Blurhash/Listener/GenerateBlurhashMetadata.php#L57-L61 So when we upload images, a blurhash will only be available after the next background run, which might limit the usefulness a bit... |
Hmpf, makes sense performancewise, but yeah kind of kills the feature |
Signed-off-by: skalidindi53 <s.teja2004@gmail.com>
0c728ea
to
51d419b
Compare
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required