-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kt verification/dev33 auto isf plugin #3161
Kt verification/dev33 auto isf plugin #3161
Conversation
…t_verification/dev33_AutoISFPlugin
Quality Gate failedFailed conditions 20 Security Hotspots See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
How different is this version of autoISF from the previous version which was based on 3.1.x? I have tested that before but I'm very wary to have that for a wider audiance as I found that misuse of the settings can lead to severe overdosing. Also I found the settings to be hard to understand. If this version is improved and addressed these concerns I'd like to know and will test again |
@jbr7rr This version is included in a dedicated plugin (it's not the case in previous version of autoISF) and can be used only after beginning of objective 11 (so definitivly not for beginners, you must be skilled users). I let @ga-zelle complete my first answer... |
I agree with what @Philoul said. Before it becomes part of a master release dedicated objectives need to be implemented. Only then can the range of parameters be widened to allow its use in Full Closed Loop mode as advocated by BerNie. Intially, in dev mode objective 11 is a good start as it ensures experience with loop and SMB. For production use specific knowledge should be proven on how it works for which objective 11 is clearly unsuited. Don't forget that even without Full Closed Loop and with a narrowed range of parameters it offers clear improvements . |
outdated, see later PR |
AutoISF Plugin
AutoISF is an extension of the SMB algorithm and modulates the profile ISF
based on certain patterns in the recent glucose history.
The full list of capabilities as available in the current stand-alone-solution is described in https://github.com/ga-zelle/autoISF/blob/A3.2.0.2_ai3.0/autoISF3.0_Quick_Guide.pdf
Most of those features get enabled with this PR with 3 exceptions:
This probably requires a debate first of how to handle and organise secondary data like steps and heart rates.
This has to wait for potential GUI adaptations.
Behaviour of AutISF in this plugin was verified against my APS emulator
and results align with current stand alone AutoISF.
Port of javascript to kotlin
Acknowledgement
A big thank you goes to @Philoul for continued consultancy, for setting up the basics of
the plugin structure and for extending the "kt versus js" test struture
so I could include AutoISF in both.