3-in-1 determine basal.kt including AutoISF #3206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ga-zelle
changed the title
|
|
The amount of changes to determinebasal and profile is huge and makes the code unreadable. Even integration with DynISF is wrong. I'd create new plugin with new OAPSProfile |
|
superseeded by #3327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focussed on the kt variant of DetermineBasal and a replacement of the earlier js-focussed PR #3161.
It proposes to unify AutoISF also into the dev version of SMB+DynISF unified to avoid extensive code duplication for a separate DetermineBasal containing AutoISF. The principle of inclusion was based on DynISF and AutoISF being mutually exclusive in their influence because I cannot see an option to combine any of their elements.
The existing kt versus js verification tests were re-run successfully for AMA, SMB and DynISF.
Again, I want to say thank you to @Philoul for his continued interest and consultancy