AutoISF plugin prototype #3327
Open
AutoISF plugin prototype #3327
+5,923
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oISFPlugin # Conflicts: # app/src/main/kotlin/app/aaps/activities/MyPreferenceFragment.kt # core/keys/src/main/kotlin/app/aaps/core/keys/BooleanKey.kt # core/keys/src/main/kotlin/app/aaps/core/keys/IntKey.kt # core/keys/src/main/kotlin/app/aaps/core/keys/UnitDoubleKey.kt # core/keys/src/main/res/values/keys.xml # plugins/aps/src/main/kotlin/app/aaps/plugins/aps/openAPSSMB/OpenAPSSMBPlugin.kt # plugins/aps/src/main/res/values/strings.xml
…oISFPlugin # Conflicts: # core/keys/src/main/kotlin/app/aaps/core/keys/BooleanKey.kt
…nto Philoul/2-in-1-AutoISFPluginDraft
…nto Philoul/2-in-1-AutoISFPluginDraft
This reverts commit 1897694.
…nto Philoul/2-in-1-AutoISFPluginKTtestDraft
MilosKozak
reviewed
May 7, 2024
| @@ -47,5 +47,29 @@ data class OapsProfile( | |||
| //DynISF only | |||
| var variable_sens: Double, | |||
| var insulinDivisor: Int, | |||
| var TDD: Double | |||
| var TDD: Double, | |||
There was a problem hiding this comment.
Create data class OapsProfileAutoIsf : OapsProfile
this makes the profile value confusing for other algs
There was a problem hiding this comment.
I added the dedicated OapsProfileAutoIsf file (without modifying database).
😉
|
make it available in engineering mode only for now (see Autotune plugin) |
You are right, I forgot to included it in the new proposal (I made a PR to ga-zelle branch, with engineering mode + dev branch like autotune). |
Dev + Engineering mode only for AutoISF
Create OapsProfileIsf
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the hint given in the earlier submission (#3206) this version has AutoISF completely contained in its own plugin.
It represents AutoSF version 3.0 as described in https://github.com/ga-zelle/autoISF/blob/A3.2.0.2_ai3.0/autoISF3.0_Quick_Guide.pdf. However, some functionality was not yet included, namely
AutoISF version 3.0.1 is in its final testing. Once verfied it will be added and offers a reduced set of preferences and flatter preference menus.
The code was tested
A big thank you goes to @Philoul . Not only did he create the plugin structure but he also put in considerable work to align the architecture as much as possible with DynamicISF. This resulted in some code duplication but AutoISF is independent of the remaining code and can be tested and developed independantly.