Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration.rb: deal with $stdin being Nil (happend for some reason in … #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migration.rb: deal with $stdin being Nil (happend for some reason in … #278

wants to merge 1 commit into from

Conversation

stonemaster
Copy link

…production)

@astier
Copy link

astier commented Nov 3, 2020

This happens to me if I run svn2git --rebase as a cronjob:

* * * * * svn2git --rebase > ~/cron_log 2>&1

The error in ~/cron_log is then:

#<Thread:0x000055f5267eaa10 /usr/lib/ruby/gems/2.7.0/gems/svn2git-2.4.0/lib/svn2git/migration.rb:404 run> terminated with exception (report_on_exception is true):
/usr/lib/ruby/gems/2.7.0/gems/svn2git-2.4.0/lib/svn2git/migration.rb:405:in `block (2 levels) in run_command': undefined method `chomp' for nil:NilClass (NoMethodError)
	from /usr/lib/ruby/gems/2.7.0/gems/svn2git-2.4.0/lib/svn2git/migration.rb:405:in `loop'
	from /usr/lib/ruby/gems/2.7.0/gems/svn2git-2.4.0/lib/svn2git/migration.rb:405:in `block in run_command'

skull-squadron added a commit to skull-squadron/svn2git that referenced this pull request Jan 14, 2024
@skull-squadron
Close nirvdrum#284, nirvdrum#307; supersede nirvdrum#285, nirvdrum#278,
6267250 
nirvdrum#308

The proper way to do subprocess I/O is to do less.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stonemaster @astier