Fixes #284 and #259 #285
Open
Fixes #284 and #259 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git2svn sometimes parses the stdout of git commands but if the locale is not set to something like en_US it can't and fails with the following error: Running command: git branch --track "<branch>" "remotes/svn/<branch>" fatal: No se puede configurar el rastreo de información; el punto de partida 'remotes/svn/1.0' no es una rama. ******************************************************************** svn2git warning: Tracking remote SVN branches is deprecated. In a future release local branches will be created without tracking. If you must resync your branches, run: svn2git --rebase ******************************************************************** Running command: git checkout "<branch>" error: pathspec '<branch>' did not match any file(s) known to git. command failed: ... A comparable error for 'git config' will happend if a older version of git (< 1.7.4) will be used. It's never a good idea to parse messages from stdout in a special language but this simple fix parse the messages in the same manner and should support different languages.
The stdin bypass will use a local variable stdin instead of $stdin and
it will result in the following error:
Traceback (most recent call last):
2: from /usr/lib/ruby/vendor_ruby/svn2git/migration.rb:432:in `block (2 levels) in run_command'
1: from /usr/lib/ruby/vendor_ruby/svn2git/migration.rb:432:in `loop'
/usr/lib/ruby/vendor_ruby/svn2git/migration.rb:438:in `block (3 levels) in run_command': undefined local variable or method `stdin' for #<Svn2Git::Migration:0x0000555b7c945cc8> (NameError)
Did you mean? String
This fix should handle the error and uses the global stdin
th3colosso
approved these changes
Feb 17, 2022
Kellis18
approved these changes
Apr 9, 2023
skull-squadron
added a commit
to skull-squadron/svn2git
that referenced
this pull request
Jan 14, 2024
nirvdrum#308 The proper way to do subprocess I/O is to do less.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two bugs filed at debian. This patches should fix them in a minimal and reasonable way.
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=905832
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=893997