Broken build on Windows

[targos]

https://ci.nodejs.org/job/node-compile-windows/22413/label=win-vs2017/console

Error:

09:37:30 v8_base_0.lib(isolate.obj) : error LNK2001: unresolved external symbol v8_Default_embedded_blob_ [c:\workspace\node-compile-windows\node.vcxproj]
09:37:30 v8_base_0.lib(isolate.obj) : error LNK2001: unresolved external symbol v8_Default_embedded_blob_size_ [c:\workspace\node-compile-windows\node.vcxproj]
09:37:30 c:\workspace\node-compile-windows\Release\node.exe : fatal error LNK1120: 2 unresolved externals [c:\workspace\node-compile-windows\node.vcxproj]

[refack]

@targos do you know which change made this regression?

[targos]

@refack Probably this change: v8/v8@bd8ed720cfa
Corresponding gypfile update: 0b2a344

[refack]

Thanks. I think it's a GYP bug (it does not map .S files as proper files to compile).
On it.

[bzoz]

FWIW manually changing embedded.S file type fixes compilation:

[bzoz]

Got it working, a GYP issue:

diff --git a/tools/gyp/pylib/gyp/generator/msvs.py b/tools/gyp/pylib/gyp/generator/msvs.py
index 8fe9e5af23..ba585b1bfc 100644
--- a/tools/gyp/pylib/gyp/generator/msvs.py
+++ b/tools/gyp/pylib/gyp/generator/msvs.py
@@ -2171,6 +2171,9 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
   elif ext == '.asm':
     group = 'masm'
     element = 'MASM'
+  elif ext == '.S':
+    group = 'masm'
+    element = 'MASM'
   elif ext == '.idl':
     group = 'midl'
     element = 'Midl'

[refack]

Thanks @bzoz! that's the patch I came up with as well.

[bzoz]

PR with fix: nodejs/node#24553

[refack]

So FTR windows-32 is a different error:

08:44:22 c:\workspace\node-compile-windows\deps\v8\src/ia32/assembler-ia32-inl.h(282): error C2440: '?': cannot convert from 'v8::internal::Code' to 'bool' (compiling source file ..\src\snapshot\startup-deserializer.cc) [c:\workspace\node-compile-windows\deps\v8\gypfiles\v8_base_2.vcxproj]
08:44:22   c:\workspace\node-compile-windows\deps\v8\src/ia32/assembler-ia32-inl.h(282): note: Ambiguous user-defined-conversion (compiling source file ..\src\snapshot\startup-deserializer.cc)
08:44:22 c:\workspace\node-compile-windows\deps\v8\src/ia32/assembler-ia32-inl.h(281): error C2660: 'v8::internal::Assembler::set_target_address_at': function does not take 2 arguments (compiling source file ..\src\snapshot\startup-deserializer.cc) [c:\workspace\node-compile-windows\deps\v8\gypfiles\v8_base_2.vcxproj]

[vsemozhetbyt]

Still no Windows binaries in the last build?
https://nodejs.org/download/v8-canary/v12.0.0-v8-canary2018120142ec383074/

[targos]

@ryzokuken fixed the canary branch today. Should be fine in the next build

[ryzokuken]

The build is restored. Unless it's broken again, the binaries should be back up! :D

[targos]

Windows build still fails:

11:28:47      Creating library c:\ws\Release\node.lib and object c:\ws\Release\node.exp
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::BaseBuiltinsFromDSLAssembler::IsFastJSArray(class v8::internal::compiler::TNode<class v8::internal::Object>,class v8::internal::compiler::TNode<class v8::internal::Context>)" (?IsFastJSArray@BaseBuiltinsFromDSLAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$TNode@VObject@internal@v8@@@523@V?$TNode@VContext@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "private: class v8::internal::compiler::Node * __cdecl v8::internal::CodeStubAssembler::EmitKeyedSloppyArguments(class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class v8::internal::compiler::CodeAssemblerLabel *)" (?EmitKeyedSloppyArguments@CodeStubAssembler@internal@v8@@AEAAPEAVNode@compiler@23@PEAV4523@00PEAVCodeAssemblerLabel@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::Print(char const *,class v8::internal::compiler::Node *)" (?Print@CodeStubAssembler@internal@v8@@QEAAXPEBDPEAVNode@compiler@23@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::IntPtrT> __cdecl v8::internal::CodeStubAssembler::ElementOffsetFromIndex(class v8::internal::compiler::Node *,enum v8::internal::ElementsKind,enum v8::internal::CodeStubAssembler::ParameterMode,int)" (?ElementOffsetFromIndex@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UIntPtrT@internal@v8@@@compiler@23@PEAVNode@523@W4ElementsKind@23@W4ParameterMode@123@H@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::Oddball> __cdecl v8::internal::CodeStubAssembler::HasProperty(class v8::internal::compiler::SloppyTNode<class v8::internal::Context>,class v8::internal::compiler::SloppyTNode<class v8::internal::Object>,class v8::internal::compiler::SloppyTNode<class v8::internal::Object>,enum v8::internal::CodeStubAssembler::HasPropertyLookupMode)" (?HasProperty@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VOddball@internal@v8@@@compiler@23@V?$SloppyTNode@VContext@internal@v8@@@523@V?$SloppyTNode@VObject@internal@v8@@@523@1W4HasPropertyLookupMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::BranchIfNumberRelationalComparison(enum v8::internal::Operation,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class v8::internal::compiler::CodeAssemblerLabel *,class v8::internal::compiler::CodeAssemblerLabel *)" (?BranchIfNumberRelationalComparison@CodeStubAssembler@internal@v8@@QEAAXW4Operation@23@PEAVNode@compiler@23@1PEAVCodeAssemblerLabel@623@2@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::BuildFastFixedArrayForEach(class v8::internal::ZoneVector<class v8::internal::compiler::CodeAssemblerVariable *> const &,class v8::internal::compiler::Node *,enum v8::internal::ElementsKind,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class std::function<void __cdecl(class v8::internal::compiler::Node *,class v8::internal::compiler::Node *)> const &,enum v8::internal::CodeStubAssembler::ParameterMode,enum v8::internal::CodeStubAssembler::ForEachDirection)" (?BuildFastFixedArrayForEach@CodeStubAssembler@internal@v8@@QEAAXAEBV?$ZoneVector@PEAVCodeAssemblerVariable@compiler@internal@v8@@@23@PEAVNode@compiler@23@W4ElementsKind@23@11AEBV?$function@$$A6AXPEAVNode@compiler@internal@v8@@0@Z@std@@W4ParameterMode@123@W4ForEachDirection@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::Node * __cdecl v8::internal::CodeStubAssembler::BuildFastLoop(class v8::internal::ZoneVector<class v8::internal::compiler::CodeAssemblerVariable *> const &,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class std::function<void __cdecl(class v8::internal::compiler::Node *)> const &,int,enum v8::internal::CodeStubAssembler::ParameterMode,enum v8::internal::CodeStubAssembler::IndexAdvanceMode)" (?BuildFastLoop@CodeStubAssembler@internal@v8@@QEAAPEAVNode@compiler@23@AEBV?$ZoneVector@PEAVCodeAssemblerVariable@compiler@internal@v8@@@23@PEAV4523@1AEBV?$function@$$A6AXPEAVNode@compiler@internal@v8@@@Z@std@@HW4ParameterMode@123@W4IndexAdvanceMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::Increment(class v8::internal::compiler::CodeAssemblerVariable *,int,enum v8::internal::CodeStubAssembler::ParameterMode)" (?Increment@CodeStubAssembler@internal@v8@@QEAAXPEAVCodeAssemblerVariable@compiler@23@HW4ParameterMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::IsNumber(class v8::internal::compiler::SloppyTNode<class v8::internal::Object>)" (?IsNumber@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$SloppyTNode@VObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::IsString(class v8::internal::compiler::SloppyTNode<class v8::internal::HeapObject>)" (?IsString@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$SloppyTNode@VHeapObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::IsJSArray(class v8::internal::compiler::SloppyTNode<class v8::internal::HeapObject>)" (?IsJSArray@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$SloppyTNode@VHeapObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::IsJSDataView(class v8::internal::compiler::TNode<class v8::internal::HeapObject>)" (?IsJSDataView@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$TNode@VHeapObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::IsConstructor(class v8::internal::compiler::SloppyTNode<class v8::internal::HeapObject>)" (?IsConstructor@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$SloppyTNode@VHeapObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::IsCallable(class v8::internal::compiler::SloppyTNode<class v8::internal::HeapObject>)" (?IsCallable@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$SloppyTNode@VHeapObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::IsAccessorPair(class v8::internal::compiler::SloppyTNode<class v8::internal::HeapObject>)" (?IsAccessorPair@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$SloppyTNode@VHeapObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::WordT> __cdecl v8::internal::CodeStubAssembler::TimesDoubleSize(class v8::internal::compiler::SloppyTNode<struct v8::internal::WordT>)" (?TimesDoubleSize@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UWordT@internal@v8@@@compiler@23@V?$SloppyTNode@UWordT@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::WordT> __cdecl v8::internal::CodeStubAssembler::TimesPointerSize(class v8::internal::compiler::SloppyTNode<struct v8::internal::WordT>)" (?TimesPointerSize@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UWordT@internal@v8@@@compiler@23@V?$SloppyTNode@UWordT@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::Node * __cdecl v8::internal::CodeStubAssembler::CalculateNewElementsCapacity(class v8::internal::compiler::Node *,enum v8::internal::CodeStubAssembler::ParameterMode)" (?CalculateNewElementsCapacity@CodeStubAssembler@internal@v8@@QEAAPEAVNode@compiler@23@PEAV4523@W4ParameterMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::FixedArrayBase> __cdecl v8::internal::CodeStubAssembler::ExtractFixedArray(class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class v8::base::Flags<enum v8::internal::CodeStubAssembler::ExtractFixedArrayFlag,int>,enum v8::internal::CodeStubAssembler::ParameterMode,class v8::internal::compiler::TypedCodeAssemblerVariable<struct v8::internal::BoolT> *,class v8::internal::compiler::Node *)" (?ExtractFixedArray@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VFixedArrayBase@internal@v8@@@compiler@23@PEAVNode@523@000V?$Flags@W4ExtractFixedArrayFlag@CodeStubAssembler@internal@v8@@H@base@3@W4ParameterMode@123@PEAV?$TypedCodeAssemblerVariable@UBoolT@internal@v8@@@523@0@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::CopyFixedArrayElements(enum v8::internal::ElementsKind,class v8::internal::compiler::Node *,enum v8::internal::ElementsKind,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,enum v8::internal::WriteBarrierMode,enum v8::internal::CodeStubAssembler::ParameterMode,enum v8::internal::CodeStubAssembler::HoleConversionMode,class v8::internal::compiler::TypedCodeAssemblerVariable<struct v8::internal::BoolT> *)" (?CopyFixedArrayElements@CodeStubAssembler@internal@v8@@QEAAXW4ElementsKind@23@PEAVNode@compiler@23@01111W4WriteBarrierMode@23@W4ParameterMode@123@W4HoleConversionMode@123@PEAV?$TypedCodeAssemblerVariable@UBoolT@internal@v8@@@623@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::FillFixedDoubleArrayWithZero(class v8::internal::compiler::TNode<class v8::internal::FixedDoubleArray>,class v8::internal::compiler::TNode<struct v8::internal::IntPtrT>)" (?FillFixedDoubleArrayWithZero@CodeStubAssembler@internal@v8@@QEAAXV?$TNode@VFixedDoubleArray@internal@v8@@@compiler@23@V?$TNode@UIntPtrT@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::FillFixedArrayWithSmiZero(class v8::internal::compiler::TNode<class v8::internal::FixedArray>,class v8::internal::compiler::TNode<struct v8::internal::IntPtrT>)" (?FillFixedArrayWithSmiZero@CodeStubAssembler@internal@v8@@QEAAXV?$TNode@VFixedArray@internal@v8@@@compiler@23@V?$TNode@UIntPtrT@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::FillFixedArrayWithValue(enum v8::internal::ElementsKind,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,enum v8::internal::RootIndex,enum v8::internal::CodeStubAssembler::ParameterMode)" (?FillFixedArrayWithValue@CodeStubAssembler@internal@v8@@QEAAXW4ElementsKind@23@PEAVNode@compiler@23@11W4RootIndex@23@W4ParameterMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::FixedArrayBase> __cdecl v8::internal::CodeStubAssembler::AllocateFixedArray(enum v8::internal::ElementsKind,class v8::internal::compiler::Node *,enum v8::internal::CodeStubAssembler::ParameterMode,class v8::base::Flags<enum v8::internal::CodeStubAssembler::AllocationFlag,int>,class v8::internal::compiler::SloppyTNode<class v8::internal::Map>)" (?AllocateFixedArray@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VFixedArrayBase@internal@v8@@@compiler@23@W4ElementsKind@23@PEAVNode@523@W4ParameterMode@123@V?$Flags@W4AllocationFlag@CodeStubAssembler@internal@v8@@H@base@3@V?$SloppyTNode@VMap@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::JSArray> __cdecl v8::internal::CodeStubAssembler::AllocateJSArray(enum v8::internal::ElementsKind,class v8::internal::compiler::TNode<class v8::internal::Map>,class v8::internal::compiler::Node *,class v8::internal::compiler::TNode<class v8::internal::Smi>,class v8::internal::compiler::Node *,enum v8::internal::CodeStubAssembler::ParameterMode,class v8::base::Flags<enum v8::internal::CodeStubAssembler::AllocationFlag,int>)" (?AllocateJSArray@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VJSArray@internal@v8@@@compiler@23@W4ElementsKind@23@V?$TNode@VMap@internal@v8@@@523@PEAVNode@523@V?$TNode@VSmi@internal@v8@@@523@2W4ParameterMode@123@V?$Flags@W4AllocationFlag@CodeStubAssembler@internal@v8@@H@base@3@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::HeapNumber> __cdecl v8::internal::CodeStubAssembler::AllocateHeapNumberWithValue(class v8::internal::compiler::SloppyTNode<struct v8::internal::Float64T>)" (?AllocateHeapNumberWithValue@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VHeapNumber@internal@v8@@@compiler@23@V?$SloppyTNode@UFloat64T@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::Node * __cdecl v8::internal::CodeStubAssembler::AllocateCellWithValue(class v8::internal::compiler::Node *,enum v8::internal::WriteBarrierMode)" (?AllocateCellWithValue@CodeStubAssembler@internal@v8@@QEAAPEAVNode@compiler@23@PEAV4523@W4WriteBarrierMode@23@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::StoreFixedDoubleArrayHole(class v8::internal::compiler::TNode<class v8::internal::FixedDoubleArray>,class v8::internal::compiler::Node *,enum v8::internal::CodeStubAssembler::ParameterMode)" (?StoreFixedDoubleArrayHole@CodeStubAssembler@internal@v8@@QEAAXV?$TNode@VFixedDoubleArray@internal@v8@@@compiler@23@PEAVNode@523@W4ParameterMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::StoreFixedDoubleArrayElement(class v8::internal::compiler::TNode<class v8::internal::FixedDoubleArray>,class v8::internal::compiler::Node *,class v8::internal::compiler::TNode<struct v8::internal::Float64T>,enum v8::internal::CodeStubAssembler::ParameterMode)" (?StoreFixedDoubleArrayElement@CodeStubAssembler@internal@v8@@QEAAXV?$TNode@VFixedDoubleArray@internal@v8@@@compiler@23@PEAVNode@523@V?$TNode@UFloat64T@internal@v8@@@523@W4ParameterMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::StoreFixedArrayOrPropertyArrayElement(class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,class v8::internal::compiler::Node *,enum v8::internal::WriteBarrierMode,int,enum v8::internal::CodeStubAssembler::ParameterMode)" (?StoreFixedArrayOrPropertyArrayElement@CodeStubAssembler@internal@v8@@QEAAXPEAVNode@compiler@23@00W4WriteBarrierMode@23@HW4ParameterMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::Object> __cdecl v8::internal::CodeStubAssembler::LoadContextElement(class v8::internal::compiler::SloppyTNode<class v8::internal::Context>,int)" (?LoadContextElement@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VObject@internal@v8@@@compiler@23@V?$SloppyTNode@VContext@internal@v8@@@523@H@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::Float64T> __cdecl v8::internal::CodeStubAssembler::LoadFixedDoubleArrayElement(class v8::internal::compiler::SloppyTNode<class v8::internal::FixedDoubleArray>,class v8::internal::compiler::Node *,class v8::internal::MachineType,int,enum v8::internal::CodeStubAssembler::ParameterMode,class v8::internal::compiler::CodeAssemblerLabel *)" (?LoadFixedDoubleArrayElement@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UFloat64T@internal@v8@@@compiler@23@V?$SloppyTNode@VFixedDoubleArray@internal@v8@@@523@PEAVNode@523@VMachineType@23@HW4ParameterMode@123@PEAVCodeAssemblerLabel@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::MaybeObject> __cdecl v8::internal::CodeStubAssembler::LoadWeakFixedArrayElement(class v8::internal::compiler::TNode<class v8::internal::WeakFixedArray>,class v8::internal::compiler::Node *,int,enum v8::internal::CodeStubAssembler::ParameterMode,enum v8::internal::LoadSensitivity)" (?LoadWeakFixedArrayElement@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VMaybeObject@internal@v8@@@compiler@23@V?$TNode@VWeakFixedArray@internal@v8@@@523@PEAVNode@523@HW4ParameterMode@123@W4LoadSensitivity@23@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::Int32T> __cdecl v8::internal::CodeStubAssembler::LoadAndUntagToWord32FixedArrayElement(class v8::internal::compiler::TNode<class v8::internal::FixedArray>,class v8::internal::compiler::Node *,int,enum v8::internal::CodeStubAssembler::ParameterMode)" (?LoadAndUntagToWord32FixedArrayElement@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UInt32T@internal@v8@@@compiler@23@V?$TNode@VFixedArray@internal@v8@@@523@PEAVNode@523@HW4ParameterMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::Object> __cdecl v8::internal::CodeStubAssembler::LoadFixedArrayElement(class v8::internal::compiler::TNode<class v8::internal::FixedArray>,class v8::internal::compiler::Node *,int,enum v8::internal::CodeStubAssembler::ParameterMode,enum v8::internal::LoadSensitivity)" (?LoadFixedArrayElement@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VObject@internal@v8@@@compiler@23@V?$TNode@VFixedArray@internal@v8@@@523@PEAVNode@523@HW4ParameterMode@123@W4LoadSensitivity@23@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::CodeStubAssembler::FixedArrayBoundsCheck(class v8::internal::compiler::TNode<class v8::internal::FixedArrayBase>,class v8::internal::compiler::Node *,int,enum v8::internal::CodeStubAssembler::ParameterMode)" (?FixedArrayBoundsCheck@CodeStubAssembler@internal@v8@@QEAAXV?$TNode@VFixedArrayBase@internal@v8@@@compiler@23@PEAVNode@523@HW4ParameterMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::IsStrong(class v8::internal::compiler::TNode<class v8::internal::MaybeObject>)" (?IsStrong@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$TNode@VMaybeObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::Map> __cdecl v8::internal::CodeStubAssembler::LoadMap(class v8::internal::compiler::SloppyTNode<class v8::internal::HeapObject>)" (?LoadMap@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VMap@internal@v8@@@compiler@23@V?$SloppyTNode@VHeapObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::Node * __cdecl v8::internal::CodeStubAssembler::LoadObjectField(class v8::internal::compiler::SloppyTNode<class v8::internal::HeapObject>,int,class v8::internal::MachineType)" (?LoadObjectField@CodeStubAssembler@internal@v8@@QEAAPEAVNode@compiler@23@V?$SloppyTNode@VHeapObject@internal@v8@@@523@HVMachineType@23@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::Node * __cdecl v8::internal::CodeStubAssembler::LoadObjectField(class v8::internal::compiler::SloppyTNode<class v8::internal::HeapObject>,class v8::internal::compiler::SloppyTNode<struct v8::internal::IntPtrT>,class v8::internal::MachineType)" (?LoadObjectField@CodeStubAssembler@internal@v8@@QEAAPEAVNode@compiler@23@V?$SloppyTNode@VHeapObject@internal@v8@@@523@V?$SloppyTNode@UIntPtrT@internal@v8@@@523@VMachineType@23@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::TaggedIsNotSmi(class v8::internal::compiler::SloppyTNode<class v8::internal::Object>)" (?TaggedIsNotSmi@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$SloppyTNode@VObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::TaggedIsSmi(class v8::internal::compiler::SloppyTNode<class v8::internal::Object>)" (?TaggedIsSmi@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$SloppyTNode@VObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::Int32T> __cdecl v8::internal::CodeStubAssembler::TruncateIntPtrToInt32(class v8::internal::compiler::SloppyTNode<struct v8::internal::IntPtrT>)" (?TruncateIntPtrToInt32@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UInt32T@internal@v8@@@compiler@23@V?$SloppyTNode@UIntPtrT@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::Smi> __cdecl v8::internal::CodeStubAssembler::SelectSmiConstant(class v8::internal::compiler::SloppyTNode<struct v8::internal::BoolT>,class v8::internal::Smi,class v8::internal::Smi)" (?SelectSmiConstant@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VSmi@internal@v8@@@compiler@23@V?$SloppyTNode@UBoolT@internal@v8@@@523@VSmi@23@1@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::Smi> __cdecl v8::internal::CodeStubAssembler::SmiMin(class v8::internal::compiler::TNode<class v8::internal::Smi>,class v8::internal::compiler::TNode<class v8::internal::Smi>)" (?SmiMin@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VSmi@internal@v8@@@compiler@23@V4523@0@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::IntPtrT> __cdecl v8::internal::CodeStubAssembler::SmiUntag(class v8::internal::compiler::SloppyTNode<class v8::internal::Smi>)" (?SmiUntag@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UIntPtrT@internal@v8@@@compiler@23@V?$SloppyTNode@VSmi@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::Smi> __cdecl v8::internal::CodeStubAssembler::SmiTag(class v8::internal::compiler::SloppyTNode<struct v8::internal::IntPtrT>)" (?SmiTag@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VSmi@internal@v8@@@compiler@23@V?$SloppyTNode@UIntPtrT@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::IntPtrT> __cdecl v8::internal::CodeStubAssembler::IntPtrMin(class v8::internal::compiler::SloppyTNode<struct v8::internal::IntPtrT>,class v8::internal::compiler::SloppyTNode<struct v8::internal::IntPtrT>)" (?IntPtrMin@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UIntPtrT@internal@v8@@@compiler@23@V?$SloppyTNode@UIntPtrT@internal@v8@@@523@0@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::Node * __cdecl v8::internal::CodeStubAssembler::IntPtrOrSmiConstant(int,enum v8::internal::CodeStubAssembler::ParameterMode)" (?IntPtrOrSmiConstant@CodeStubAssembler@internal@v8@@QEAAPEAVNode@compiler@23@HW4ParameterMode@123@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<struct v8::internal::BoolT> __cdecl v8::internal::CodeStubAssembler::IsSharedFunctionInfoMap(class v8::internal::compiler::SloppyTNode<class v8::internal::Object>)" (?IsSharedFunctionInfoMap@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@UBoolT@internal@v8@@@compiler@23@V?$SloppyTNode@VObject@internal@v8@@@523@@Z) [c:\ws\node.vcxproj]
11:28:48 v8_base_1.lib(isolate.obj) : error LNK2001: unresolved external symbol "public: class v8::internal::compiler::TNode<class v8::internal::Object> __cdecl v8::internal::CodeStubAssembler::NoContextConstant(void)" (?NoContextConstant@CodeStubAssembler@internal@v8@@QEAA?AV?$TNode@VObject@internal@v8@@@compiler@23@XZ) [c:\ws\node.vcxproj]
11:28:48 c:\ws\Release\node.exe : fatal error LNK1120: 52 unresolved externals [c:\ws\node.vcxproj]

[ryzokuken]

@targos is it because of pending V8 upgrades? Doesn't seem to be so.

[targos]

I don't know what it is

[bzoz]

Went on searching for the first symbol: IsFastJSArray. It gets correctly generated from base.tq, placed in node\Release\obj\global_intermediate\torque-generated\builtins-test-from-dsl-gen.cc. From dumpbin it looks like this function is included in v8_initializers.lib.

Furthermore, adding this v8_initializers.lib explicitly to Node additional libraries makes Node compile:

That's all the research I was able to do today. If no one picks this up, I'll get back to this on Wednesday.

[bzoz]

Fix inm #92

[targos]

Fix landed in nodejs/node@72c318e