win: add v8_init to dependencies #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 7.3. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
Co-authored-by: Ujjwal Sharma <usharma1998@gmail.com>
Bump minimum version of ICU needed to build node to 63. Refs: v8/v8@30a350f Co-authored-by: Steven R Loomis <srloomis@us.ibm.com>
New heap space: code_large_object_space
until cb242eded633b55856156da6276f961e63f64253
until 2f852e5e544d97b1b67fef6b68240050d465cf25
until 9362fa94783760a8536d24ef16f17d4489fcd8a9
Closed
richardlau
approved these changes
Dec 11, 2018
|
Thank you! This also affects V8 7.2 so I'll include this in nodejs/node#24875 |
|
Failures are unrelated. Build on x64 was a success: https://ci.nodejs.org/job/node-compile-windows/23051/ |
|
Landed in nodejs/node@72c318e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
v8_initializerswhere missing form v8 dependencies.Fixes: #89
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes