Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added meta data from v8.1.0 was not added. Mistakenly lists some APIs as added in 9.0.0 #17026

Closed
MylesBorins opened this issue Nov 14, 2017 · 2 comments
Closed

Added meta data from v8.1.0 was not added. Mistakenly lists some APIs as added in 9.0.0 #17026

MylesBorins opened this issue Nov 14, 2017 · 2 comments
Labels
good first issue Issues that are suitable for first-time contributors.

Comments

@MylesBorins
Copy link
Contributor

Original Commit: f6fc46e
Commit on Master: d7f6919

The added labels were not updated meaning a number of APIs now have 9.0.0 instead of 8.1.0

This should be fixed and we may want to review other semver minors
@MylesBorins MylesBorins added the good first issue Issues that are suitable for first-time contributors. label Nov 14, 2017
@sabakugaara sabakugaara mentioned this issue Nov 16, 2017
Closed
2 tasks
@sabakugaara
Copy link
Contributor

@MylesBorins 😄

@MylesBorins
Copy link
Contributor Author

thanks @sabakugaara !!!

MylesBorins pushed a commit that referenced this issue Nov 16, 2017
@sabakugaara @MylesBorins
doc: correct the wrong added meta data
667f8c6 
PR-URL: #17072
Fixes: #17026
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this issue Dec 11, 2017
@sabakugaara @MylesBorins
doc: correct the wrong added meta data
b87030c 
PR-URL: #17072
Fixes: #17026
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this issue May 5, 2024
@sabakugaara
doc: correct the wrong added meta data
4f2ec57 
Fixes: nodejs/node#17026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MylesBorins @sabakugaara