Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct the wrong added meta data #17072

Closed
wants to merge 1 commit into from
Closed

doc: correct the wrong added meta data #17072

wants to merge 1 commit into from

Conversation

sabakugaara
Copy link
Contributor

Fixes: #17026

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 16, 2017
MylesBorins
MylesBorins approved these changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Doesn't need to wait 48 hours I don't think

@MylesBorins
Copy link
Contributor

landed in 667f8c6

MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@sabakugaara @MylesBorins
doc: correct the wrong added meta data
667f8c6 
PR-URL: #17072
Fixes: #17026
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@watson
Copy link
Member

watson commented Nov 24, 2017

@MylesBorins Currently the default version of the docs still show the wrong version. I'm not sure where the default version of the docs are build from, but if it's the v9.x branch then that still contain the wrong version numbers.

MylesBorins pushed a commit that referenced this pull request Dec 11, 2017
@sabakugaara @MylesBorins
doc: correct the wrong added meta data
b87030c 
PR-URL: #17072
Fixes: #17026
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sabakugaara @MylesBorins @watson @jasnell @nodejs-github-bot