Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test test-child-process-emfile #2666

Closed
joaocgreis opened this issue Sep 2, 2015 · 10 comments
Closed

Investigate flaky test test-child-process-emfile #2666

joaocgreis opened this issue Sep 2, 2015 · 10 comments
Labels
build Issues and PRs related to build files or the CI. child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.

Comments

@joaocgreis
Copy link
Member

Examples of failures:

Ref: #2636 (comment)
@joaocgreis joaocgreis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Sep 2, 2015
@joaocgreis
Copy link
Member Author

Both happened in the new iojs-nodesource-raspbian-wheezy-pi2-7-mininodes

@joaocgreis
Copy link
Member Author

Another one, again in pi2-7

@joaocgreis joaocgreis mentioned this issue Sep 2, 2015
Closed
orangemocha added a commit to orangemocha/io.js that referenced this issue Sep 3, 2015
@orangemocha
test: test-child-process-emfile is flaky
eeac5da 
Ref: nodejs#2666
@orangemocha orangemocha mentioned this issue Sep 3, 2015
Closed
@Fishrock123
Copy link
Contributor

Why don't these tests show error output?

@brendanashworth brendanashworth added the child_process Issues and PRs related to the child_process subsystem. label Sep 3, 2015
@rvagg
Copy link
Member

rvagg commented Sep 3, 2015

rebooted pi2-7, just in case it's something related to just being set up yesterday and not having a reboot since

@skomski
Copy link
Contributor

skomski commented Sep 3, 2015

@Fishrock123 because they timed out - pr #2647 would make that visible

@jbergstroem
Copy link
Member

Can't say I've seen this around either.

@joaocgreis
Copy link
Member Author

Different platform: centos5-32: https://ci.nodejs.org/job/node-test-commit-linux/462/nodes=centos5-32/console

@Trott
Copy link
Member

Trott commented Oct 13, 2015

Seems to mostly/only fail on FreeBSD lately. #3335 isn't a fix but may at least help point someone in the right direction.

@Trott
Copy link
Member

Trott commented Oct 19, 2015

The test treats ENFILE the same as EMFILE. But ENFILE is a race condition because another process can trigger it temporarily. That seems to be the cause of the flakiness. PR coming momentarily.

@Trott Trott mentioned this issue Oct 19, 2015
Closed
@Trott
Copy link
Member

Trott commented Oct 19, 2015

Proposed fix in #3430

Trott added a commit to Trott/io.js that referenced this issue Oct 20, 2015
@Trott
test: fix flaky test-child-process-emfile
421b571 
Require the test setup to obtain an EMFILE error and not ENFILE as
ENFILE means there is a race condition with other processes that may
close files before `spawn()` is called by the test.

Fixes: nodejs#2666
@Trott Trott closed this as completed in d89bc7b Oct 20, 2015
Trott added a commit that referenced this issue Oct 21, 2015
@Trott @rvagg
test: fix flaky test-child-process-emfile
04fb14c 
Require the test setup to obtain an EMFILE error and not ENFILE as
ENFILE means there is a race condition with other processes that may
close files before `spawn()` is called by the test.

Fixes: #2666
PR-URL: #3430
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit that referenced this issue Oct 26, 2015
@Trott @jasnell
test: fix flaky test-child-process-emfile
0b32414 
Require the test setup to obtain an EMFILE error and not ENFILE as
ENFILE means there is a race condition with other processes that may
close files before `spawn()` is called by the test.

Fixes: #2666
PR-URL: #3430
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit that referenced this issue Oct 29, 2015
@Trott @jasnell
test: fix flaky test-child-process-emfile
a5d968b 
Require the test setup to obtain an EMFILE error and not ENFILE as
ENFILE means there is a race condition with other processes that may
close files before `spawn()` is called by the test.

Fixes: #2666
PR-URL: #3430
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky test-child-process-emfile Trott/io.js
7 participants
@joaocgreis @skomski @jbergstroem @rvagg @Trott @Fishrock123 @brendanashworth