Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: better message for test-child-process-emfile failures #3335

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 13, 2015

When the test fails (as it does frequently on FreeBSD unfortunately)
provide a non-cryptic error message that also provides a meaningful line
number (test-child-process-emfile.js:33).

Before:

#assert.js:87
#  throw new assert.AssertionError({
#  ^
#AssertionError: 0 undefined null
#    at emitTwo (events.js:87:13)
#    at ChildProcess.emit (events.js:172:7)
#    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

After:

#assert.js:89
#  throw new assert.AssertionError({
#  ^
#AssertionError: "exit" should not be emitted (the process never spawned!)
#    at ChildProcess.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-other/nodes/freebsd101-64/test/sequential/test-child-process-emfile.js:33:10)
#    at emitTwo (events.js:87:13)
#    at ChildProcess.emit (events.js:172:7)
#    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

@Trott Trott added the test Issues and PRs related to the tests. label Oct 13, 2015
@Trott
Copy link
Member Author

Trott commented Oct 13, 2015

@bnoordhuis
Copy link
Member

LGTM but the subject line is > 50 characters.

When the test fails (as it does frequently on FreeBSD unfortunately)
provide a non-cryptic error message that also provides a line number.
@Trott
Copy link
Member Author

Trott commented Oct 13, 2015

Squashed commits, fixed > 50 char commit log line

Trott added a commit that referenced this pull request Oct 14, 2015
When the test fails (as it does frequently on FreeBSD unfortunately)
provide a non-cryptic error message that also provides a line number.

PR-URL: #3335
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott
Copy link
Member Author

Trott commented Oct 14, 2015

Landed in e3d9d25

@Trott Trott closed this Oct 14, 2015
@rvagg rvagg mentioned this pull request Oct 21, 2015
@MylesBorins
Copy link
Contributor

consideration for LTS?
@jasnell

Trott added a commit that referenced this pull request Oct 26, 2015
When the test fails (as it does frequently on FreeBSD unfortunately)
provide a non-cryptic error message that also provides a line number.

PR-URL: #3335
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jasnell
Copy link
Member

jasnell commented Oct 26, 2015

Landed in v4.x-staging in e43c611

Trott added a commit that referenced this pull request Oct 29, 2015
When the test fails (as it does frequently on FreeBSD unfortunately)
provide a non-cryptic error message that also provides a line number.

PR-URL: #3335
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott Trott deleted the debug-freebsd branch January 13, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants