test: http test improvements #14315

jasnell · 2017-07-17T00:49:21Z

Generalized http test suite improvements...

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

benjamingr · 2017-07-17T07:10:52Z

test/parallel/test-http-blank-header.js

  assert.strictEqual('GET', req.method);
  assert.strictEqual('/blah', req.url);
  assert.deepStrictEqual({
-    host: 'mapdevel.trolologames.ru:443',


benjamingr · 2017-07-17T07:12:16Z

test/parallel/test-http-client-agent.js

-server.listen(0, function() {
-  name = http.globalAgent.getName({ port: this.address().port });
-  for (let i = 0; i < max; ++i) {
+}, 3));


Why did you add this?

Just tightening up the tests to be more strict.

benjamingr · 2017-07-17T07:14:00Z

test/parallel/test-http-client-check-http-token.js

    assert.throws(() => {
-      http.request({ method: input, path: '/' }, common.mustNotCall());
+      http.request({ method: method, path: '/' }, common.mustNotCall());


this can be a shorthand. { method, path: '/'}. Also this test structure is a bit strange - and I'm not sure that in this case the code is clearer after the refactoring. Personally I would prefer a for... of but it's not a big deal.

benjamingr · 2017-07-17T07:14:22Z

test/parallel/test-http-client-check-http-token.js

    assert.throws(() => {
-      http.request({ method: input, path: '/' }, common.mustNotCall());
+      http.request({ method: method, path: '/' }, common.mustNotCall());
    }, /^TypeError: Method must be a string$/);


It might be good to add a Symbol to the list of expectedFails while we're touching these

benjamingr

Left a few nits - overall nice work with the countdown.
This is also a pretty big diff.

refack · 2017-07-17T12:41:13Z

/cc @nodejs/testing @nodejs/http

jasnell · 2017-07-17T23:27:45Z

@benjamingr ... nits addressed!

vsemozhetbyt · 2017-07-20T21:24:52Z

It seems this should be added before the code example in README.md to pass linting:

<!-- eslint-disable strict, required-modules -->

jasnell · 2017-07-24T16:32:15Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/9327/

* Add common/countdown utility * Numerous improvements to http tests

* Add common/countdown utility * Numerous improvements to http tests PR-URL: #14315 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

jasnell · 2017-07-24T21:31:12Z

Landed in b0a8a7c, squashed and a lint issue fixed in the process.

jasnell · 2017-07-24T21:32:33Z

@nodejs/codeandlearn ... As a future exercise for code-n-learn participants, there are a non-trivial number of existing tests that can be modified to use the new common/countdown module... for instance, to shutdown a server after a given number of test requests have completed.

gibfahn · 2017-07-25T01:06:31Z

Seems like there should be some more people in @nodejs/codeandlearn (I know @Trott and @addaleax have been heavily involved, and I'm sure there are others who are interested).

addaleax · 2017-07-27T22:31:16Z

This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR.

* Add common/countdown utility * Numerous improvements to http tests PR-URL: nodejs#14315 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

* Add common/countdown utility * Numerous improvements to http tests Backport-PR-URL: #14583 Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #14315 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MylesBorins · 2017-08-16T08:29:08Z

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

* Add common/countdown utility * Numerous improvements to http tests PR-URL: #14315 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 17, 2017

jasnell force-pushed the http-test-improvements branch from a03f0e0 to 8f50438 Compare July 17, 2017 00:55

jasnell changed the title ~~Http test improvements~~ test: http test improvements Jul 17, 2017

mscdex added the http Issues or PRs related to the http subsystem. label Jul 17, 2017

benjamingr reviewed Jul 17, 2017

View reviewed changes

benjamingr approved these changes Jul 17, 2017

View reviewed changes

refack mentioned this pull request Jul 17, 2017

False successfully end of request #8102

Closed

jasnell force-pushed the http-test-improvements branch from efcd158 to 582ce9b Compare July 17, 2017 23:27

jasnell mentioned this pull request Jul 24, 2017

test: improve numerous http tests #12930

Closed

3 tasks

jasnell force-pushed the http-test-improvements branch from 582ce9b to 1fccc7b Compare July 24, 2017 16:31

test: improvements to various http tests

9062d47

* Add common/countdown utility * Numerous improvements to http tests

jasnell force-pushed the http-test-improvements branch from 1fccc7b to 9062d47 Compare July 24, 2017 21:14

jasnell added a commit that referenced this pull request Jul 24, 2017

test: improvements to various http tests

b0a8a7c

* Add common/countdown utility * Numerous improvements to http tests PR-URL: #14315 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

jasnell closed this Jul 24, 2017

addaleax added the backport-requested-v8.x label Jul 27, 2017

jasnell added a commit to jasnell/node that referenced this pull request Aug 1, 2017

test: improvements to various http tests

4cddc05

* Add common/countdown utility * Numerous improvements to http tests PR-URL: nodejs#14315 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

jasnell mentioned this pull request Aug 1, 2017

[8.x] Backport http test improvements #14583

Closed

3 tasks

addaleax added backported-to-v8.x and removed backport-requested-v8.x labels Aug 1, 2017

addaleax mentioned this pull request Aug 2, 2017

v8.3.0 proposal #14594

Merged

MylesBorins added the backport-requested-v6.x label Aug 16, 2017

MylesBorins added land-on-v6.x and removed backport-requested-v6.x labels Sep 19, 2017

MylesBorins pushed a commit that referenced this pull request Sep 19, 2017

test: improvements to various http tests

c88f99f

* Add common/countdown utility * Numerous improvements to http tests PR-URL: #14315 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MylesBorins mentioned this pull request Sep 20, 2017

v6.11.4 proposal #15506

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: http test improvements #14315

test: http test improvements #14315

jasnell commented Jul 17, 2017 •

edited

Loading

benjamingr Jul 17, 2017

benjamingr Jul 17, 2017

jasnell Jul 17, 2017

benjamingr Jul 17, 2017

benjamingr Jul 17, 2017

benjamingr left a comment

refack commented Jul 17, 2017

jasnell commented Jul 17, 2017

vsemozhetbyt commented Jul 20, 2017

jasnell commented Jul 24, 2017

jasnell commented Jul 24, 2017

jasnell commented Jul 24, 2017

gibfahn commented Jul 25, 2017 •

edited

Loading

addaleax commented Jul 27, 2017

MylesBorins commented Aug 16, 2017

test: http test improvements #14315

test: http test improvements #14315

Conversation

jasnell commented Jul 17, 2017 • edited Loading

Checklist

Affected core subsystem(s)

benjamingr Jul 17, 2017

Choose a reason for hiding this comment

benjamingr Jul 17, 2017

Choose a reason for hiding this comment

jasnell Jul 17, 2017

Choose a reason for hiding this comment

benjamingr Jul 17, 2017

Choose a reason for hiding this comment

benjamingr Jul 17, 2017

Choose a reason for hiding this comment

benjamingr left a comment

Choose a reason for hiding this comment

refack commented Jul 17, 2017

jasnell commented Jul 17, 2017

vsemozhetbyt commented Jul 20, 2017

jasnell commented Jul 24, 2017

jasnell commented Jul 24, 2017

jasnell commented Jul 24, 2017

gibfahn commented Jul 25, 2017 • edited Loading

addaleax commented Jul 27, 2017

MylesBorins commented Aug 16, 2017

jasnell commented Jul 17, 2017 •

edited

Loading

gibfahn commented Jul 25, 2017 •

edited

Loading