Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.11.4 proposal #15506

Merged
merged 92 commits into from
Oct 3, 2017
Merged

v6.11.4 proposal #15506

merged 92 commits into from
Oct 3, 2017

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Sep 20, 2017 •
edited
Loading

2017-10-03, Version 6.11.4 'Boron' (LTS), @MylesBorins

This LTS release comes with 91 commits. This includes 29 which are test related,
28 which are doc related, 11 which are build / tool related and 3 commits which are updates to dependencies.

Notable Changes

  • net:
    • support passing undefined to listen() to match behavior in v4.x and v8.x (Sam Roberts) #14234

Commits

BridgeAR and others added 30 commits September 19, 2017 09:09
@BridgeAR @MylesBorins
net: fix abort on bad address input
792acc1 
Backport-PR-URL: #14390
PR-URL: #13726
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@vsemozhetbyt @MylesBorins
doc, lib, test: do not re-require needlessly
38ae5c4 
PR-URL: #14244
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@MylesBorins
build: add cpp linting to windows build
66cdcd9 
This PR adds cpp linting to windows build script. After this change,
running command `vcbuild lint` will run both cpp linting and javascript
linting on a windows machine.

Backport-PR-URL: #14879
PR-URL: #11856
Fixes: #11816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@brennemo @MylesBorins
build: add lint option to vcbuild.bat help
c9ae894 
180bec1
PR-URL: #11992
Fixes: #11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@kfarnung @MylesBorins
build: split up cpplint to avoid long cmd lines
14cc1ab 
Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.

Backport-PR-URL: #14879
PR-URL: #14116
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@Azard @MylesBorins
readline: remove max limit of crlfDelay
8604772 
Backport-PR-URL: #14899
PR-URL: #13497
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@Azard @MylesBorins
test: fix test-readline-interface
8dfc283 
Previous unit test delay is too short for parallel test on raspberry pi,
it will fail sometimes.  This PR use common.platformTimeout and widen
the time gap.

PR-URL: #14677
Ref: #14674
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos @MylesBorins
deps: backport 071b655 from V8 upstream
921876d 
Original commit message:

    [PATCH] [debugger] Scope iterator should not visit inner function literals.

    R=marja@chromium.org
    BUG=chromium:621361

    Review-Url: https://codereview.chromium.org/2185913003
    Cr-Commit-Position: refs/heads/master@{#38087}

Fixes: #15075

PR-URL: #15215
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Trott @MylesBorins
tools: replace assert-throw-arguments custom lint
f8b85e1 
The functionality of ESLint custom rule assert-throws-arguments can be
replaced with no-restricted-syntax entries.

Backport-PR-URL: #15253
PR-URL: #14547
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jBarz @MylesBorins
deps: backport 0353a1e from V8 upstream
4e1a50a 
Original commit message:

  Avoid disassembling Interpreted Regexp code

  I found that v8 will crash when --print-code is turned on while Regexp
  is interpreted. It crashes when trying to print Relocation info during
  Disassembly. It should probably avoid printing out disassembly when the
  Code object is a bytecode regexp.

  Bug:
  Change-Id: I35b531cb03996a303248652871452266c78fee38
  Reviewed-on: https://chromium-review.googlesource.com/642127
  Reviewed-by: Yang Guo <yangguo@chromium.org>

PR-URL: #15287
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TimothyGu @MylesBorins
doc: add documentation on ICU
90fcccd 
PR-URL: #13916
Refs: #13644 (comment)
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@shivanth @MylesBorins
repl: do not consider ... as a REPL command
362a7c0 
This fix makes ... in REPL to be considered as a javascript construct
rather than a REPL keyword.

Fixes: #14426
Backport-PR-URL: #14915
PR-URL: #14467
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@refack @MylesBorins
tools: eslint - use error and off
f7b6d19 
Backport-PR-URL: #14841
PR-URL: #14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@refack @MylesBorins
test: mark inspector-port-zero-cluster as flaky
86497f1 
Ref: #13343
@gireeshpunathil @MylesBorins
http: assert parser.consume argument's type
e65c9ec 
Unchecked argument conversion in Parser::Consume crashes node
in an slightly undesirable manner - 'unreachable code' in parser.

Make sure we validate the incoming type at the earliest point.

PR-URL: #12288
Fixes: #12178
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@STRML @MylesBorins
doc: add readline.emitKeypressEvents note
594e3c2 
PR-URL: #9447
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins
doc: fix typo in stream.md
dcdc905 
PR-URL: #14364
Fixes: #14362
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@bnoordhuis @MylesBorins
tls: fix empty issuer/subject/infoAccess parsing
3a6392b 
Also issuerCertificate but that did not fit on the status line.

Fixes: #11771
PR-URL: #14473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@bzoz @MylesBorins
test: read proper inspector message size
8b9a05c 
Fix a bug when messages bigger than 64kb where incorrectly parsed by
the inspector-helper.

PR-URL: #14596
Fixes: #14507
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@kapouer @MylesBorins
test: use ciphers supported by shared OpenSSL
860c619 
On Debian with OpenSSL 1.1 CLI, the ciphers used in those tests were
unknown.

PR-URL: #14566
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell @MylesBorins
test: improvements to various http tests
c88f99f 
* Add common/countdown utility
* Numerous improvements to http tests

PR-URL: #14315
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@jasnell @MylesBorins
test: improve multiple timers tests
fc49cf4 
PR-URL: #14616
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@Trott @MylesBorins
test: improve check in test-os
28b77d1 
The check for `os.networkInterfaces()` in `test-os.js` may be too
strict. It's apparently possible for a machine to be configured with
multiple IPv4 loopback interfaces. Increase specificity of filter to
check on only the object we expect.

PR-URL: #14655
Fixes: #14654
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nickstanish @MylesBorins
test: fix conversion of microseconds in test
9d84641 
PR-URL: #14706
Fixes: #8728
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@danbev @MylesBorins
doc: fix order of AtExit callbacks in addons.md
c0e47e4 
The sanity_check AtExit callback needs to come last to verify that the
other callbacks have been completed. This was not noticed before as this
code was not been executed.

PR-URL: #14048
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danbev @MylesBorins
doc: remove undef NDEBUG from addons.md
b5904a2 
When working on commit 0d95a0b
("test: remove undef NDEBUG from at-exit addons test) I searched for
usages of undef NDEBUG but did not include the doc directory (but I did
include the test directory) and missed this one.

Commit 1f02569f8db9cb0101807df4982534738f0161b2 ("tools: fix
tools/addon-verify.js") enables the code in the "AtExit" section to be
included in the test/addons diretory and this code will again be
tested.

PR-URL: #14048
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danbev @MylesBorins
tools: fix tools/addon-verify.js
ca61f3b 
The current implementation of addon-verify.js is including the code
for the "Function arguments" section in test/addons/01_callbacks and
there is no directory generated or the "Function arguments section".
This continues and leads to the last section, "AtExit", code to be
excluded. There is an test/addons/07_atexit_hooks but it contains code
from the "Passing wrapped objects around" section.

This commit modifies addon-verify to associate headers with code and
then iterates over the set and generates the files as a separate step.

PR-URL: #14048
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@addaleax @MylesBorins
http: reset stream to unconsumed in unconsume()
6707411 
Reset the underlying socket of an HTTP stream to be marked as
unconsume after the HTTP parser no longer owns it.

Fixes: #14407
PR-URL: #14410
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@prakaashkpk @MylesBorins
test: set module loading error for aix
4fb755c 
In test/parallel/test-module-loading-error.js, an attempt is made to
load a text file as a native executable. This results in an error
message in a platform specific manner.

AIX was not included in the list of platforms. This fix introduces
the AIX error messages.

PR-URL: #14511
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@Trott @MylesBorins
test: add block scoping to test-readline-interface
9ed2c4c 
Use block-scoping in test-readline-interface to avoid side effects and
make tests more modular. (Some contain race conditions and will need to
be moved to the sequential directory if they can't be refactored to
avoid the race condition.)

Backport-PR-URL: #14748
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #14615
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sam-github and others added 7 commits September 25, 2017 23:42
@sam-github @MylesBorins
doc: describe what security issues are
33fdbb5 
PR-URL: #14485
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jalafel @MylesBorins
doc: document bytes to chars after setEncoding
feb6863 
This commit documents and edge-case behavior in readable streams.
It is expected that non-object streams are measured in bytes
against the highWaterMark. However, it was discovered in issue
thereafter begin to measure the buffer's length in characters.

PR-URL: #13442
Refs: #6798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@danbev @MylesBorins
test: check zlib version for createDeflateRaw
8e00315 
We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:
- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt
Backport-PR-URL: #15478
PR-URL: #13697
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@evantorrie @MylesBorins
http: eliminate capture of ClientRequest in Agent
0c670e0 
Keepalive sockets that are returned to the agent's freesocket pool were
previously capturing a reference to the ClientRequest that initiated the
request.

This commit eliminates that by moving the installation of the socket
listeners to a different function.

Backport-PR-URL: #15500
PR-URL: #10134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR @MylesBorins
assert: refactor the code
73416b4 
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments

Backport-PR-URL: #15516
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeAR @MylesBorins
doc,assert: document stackStartFunction in fail
abf6355 
Backport-PR-URL: #15516
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@gibfahn @MylesBorins
test: remove envPlus, use Object.assign everywhere
2c8fe97 
PR-URL: #14845
Backport-PR-URL: #15557
Fixes: #14823
Refs: #14822
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Sep 26, 2017
@MylesBorins
2017-10-03, Version 6.11.4 'Boron' (LTS)
be4eab5 
Notable Changes:

Coming Soon

PR-URL: #15506
@MylesBorins
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/10269/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1001/
rc.2: https://nodejs.org/download/rc/v6.11.4-rc.2/

@mscdex mscdex removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Sep 26, 2017
@MylesBorins
Copy link
Contributor Author

CI is green 🎉

running citgm one more time

citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1003/

Chris Young and others added 3 commits September 29, 2017 13:31
@MylesBorins
doc: add links to alternative versions of doc
ecea33b 
Each page of the API documentation should have links to other versions
of the same page. This will make it easier to switch between the current
"live" release at nodejs.org and LTS versions.

Backport-PR-URL: #15670
PR-URL: #10958
Fixes: #10726
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos @MylesBorins
tools: fix linter error in html.js
37dd2ad 
Backport-PR-URL: #15670
PR-URL: #15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins
doc: prevent displaying empty version picker
a13ac69 
Backport-PR-URL: #15670
PR-URL: #15420
Fixes: #15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this pull request Sep 29, 2017
@MylesBorins
2017-10-03, Version 6.11.4 'Boron' (LTS)
bd7bb04 
Notable Changes:

Coming Soon

PR-URL: #15506
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Sep 29, 2017 •
edited
Loading

CITGM looks good.

Updated docs generator, one more run + r.c. to check it out

ci: https://ci.nodejs.org/job/node-test-pull-request/10338/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1004/
rc.3: https://nodejs.org/download/rc/v6.11.4-rc.3/

@MylesBorins
2017-10-03, Version 6.11.4 'Boron' (LTS)
8691fdf 
Notable Changes:

* net:
  - support passing undefined to listen() to match behavior in v4.x
    and v8.x (Sam Roberts)
    #14234

PR-URL: #15506
@MylesBorins MylesBorins merged commit 8691fdf into v6.x Oct 3, 2017
MylesBorins added a commit that referenced this pull request Oct 3, 2017
@MylesBorins
Working on v6.11.5
452cd40 
PR-URL: #15506
MylesBorins added a commit that referenced this pull request Oct 3, 2017
@MylesBorins
2017-10-03, Version 6.11.4 'Boron' (LTS)
9e8f4b3 
Notable Changes:

* net:
  - support passing undefined to listen() to match behavior in v4.x
    and v8.x (Sam Roberts)
    #14234

PR-URL: #15506
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@MylesBorins @addaleax
2017-10-03, Version 6.11.4 'Boron' (LTS)
f51fbea 
Notable Changes:

* net:
  - support passing undefined to listen() to match behavior in v4.x
    and v8.x (Sam Roberts)
    nodejs/node#14234

PR-URL: nodejs/node#15506
@MylesBorins MylesBorins deleted the v6.11.4-proposal branch October 10, 2017 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.