Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add missing console.error to exec-maxBuffer #14796

Closed
wants to merge 1 commit into from
Closed

test: add missing console.error to exec-maxBuffer #14796

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

While looking at this test I noticed that the final cmd calls console.('${unicode}'). To me, it wasn't clear if this was intentional or if it should be console.error('${unicode}').

https://github.com/nodejs/node/blob/master/test/parallel/test-child-process-exec-maxBuffer.js#L39

If it was intentional I am happy for this to be closed and/or I can add a comment to the test.

/cc @Trott as author of the test case

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@BethGriggs
test: add missing console.error to exec-maxBuffer
bc43409 
Adds the missing console.error to test-child-process-exec-maxBuffer
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 12, 2017
@vsemozhetbyt vsemozhetbyt added the child_process Issues and PRs related to the child_process subsystem. label Aug 12, 2017
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Aug 12, 2017 •
edited by gibfahn
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/9634/

EDIT(gibfahn): CI was green except for an ARM flake.

gibfahn
gibfahn approved these changes Aug 12, 2017
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd appreciate confirmation from @Trott

@gibfahn gibfahn requested a review from Trott August 12, 2017 23:17
@Trott
Copy link
Member

Trott commented Aug 13, 2017

Sure looks like an error on my part. Thanks for catching it and fixing it.

@gibfahn gibfahn force-pushed the fix-child-process-exec-maxbuff branch from 86af084 to bc43409 Compare August 13, 2017 17:05
@tniessen
Copy link
Member

Landed in 4f1eddf, thank you! 🎉

@tniessen tniessen closed this Aug 16, 2017
tniessen pushed a commit that referenced this pull request Aug 16, 2017
@BethGriggs @tniessen
test: add missing console.error to exec-maxBuffer
4f1eddf 
Adds the missing console.error to test-child-process-exec-maxBuffer

PR-URL: #14796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MSLaguana pushed a commit to nodejs/node-chakracore that referenced this pull request Aug 21, 2017
@BethGriggs @MSLaguana
test: add missing console.error to exec-maxBuffer
e44983b 
Adds the missing console.error to test-child-process-exec-maxBuffer

PR-URL: nodejs/node#14796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@BethGriggs @MylesBorins
test: add missing console.error to exec-maxBuffer
27ec693 
Adds the missing console.error to test-child-process-exec-maxBuffer

PR-URL: #14796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 20, 2017
@BethGriggs @MylesBorins
test: add missing console.error to exec-maxBuffer
4fb4fbe 
Adds the missing console.error to test-child-process-exec-maxBuffer

PR-URL: #14796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Merged
@BethGriggs BethGriggs deleted the fix-child-process-exec-maxbuff branch February 21, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@aqrln aqrln aqrln approved these changes

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.